From 30e16eed40773b9f81074cb08fab3dfa8f322316 Mon Sep 17 00:00:00 2001 From: Christian Bruckmayer <3799140+ChrisBr@users.noreply.github.com> Date: Mon, 17 Mar 2025 15:40:08 +0000 Subject: [PATCH] Revert "Dump JSON directly to file instead of buffering" --- ruby/lib/minitest/queue/build_status_reporter.rb | 4 ++-- ruby/lib/minitest/queue/runner.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ruby/lib/minitest/queue/build_status_reporter.rb b/ruby/lib/minitest/queue/build_status_reporter.rb index d9344512..ea59269f 100644 --- a/ruby/lib/minitest/queue/build_status_reporter.rb +++ b/ruby/lib/minitest/queue/build_status_reporter.rb @@ -107,11 +107,11 @@ def progress end def write_failure_file(file) - JSON.dump(error_reports.map(&:to_h), File.open(file, 'w')) + File.write(file, error_reports.map(&:to_h).to_json) end def write_flaky_tests_file(file) - JSON.dump(flaky_reports, File.open(file, 'w')) + File.write(file, flaky_reports.to_json) end private diff --git a/ruby/lib/minitest/queue/runner.rb b/ruby/lib/minitest/queue/runner.rb index 79c1a917..31183a82 100644 --- a/ruby/lib/minitest/queue/runner.rb +++ b/ruby/lib/minitest/queue/runner.rb @@ -323,7 +323,7 @@ def display_warnings(build) warnings = build.pop_warnings.map do |type, attributes| attributes.merge(type: type) end.compact - JSON.dump(warnings, File.open(queue_config.warnings_file, 'w')) + File.write(queue_config.warnings_file, warnings.to_json) end def run_tests_in_fork(queue)