Fix a crash with acknowledge keyword when using static queue

[anmarchenko]

When running tests for datadog-ci gem with latest ci-queue I noticed the following crash:

ArgumentError: unknown keyword: :acknowledge
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/ci-queue-0.68.0/lib/ci/queue/build_record.rb:26:in 'record_success'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/ci-queue-0.68.0/lib/minitest/queue/build_status_recorder.rb:55:in 'Minitest::Queue::BuildStatusRecorder#record'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/minitest-reporters-1.7.1/lib/minitest/minitest_reporter_plugin.rb:27:in 'block in Minitest::Reporters::DelegateReporter#record'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/minitest-reporters-1.7.1/lib/minitest/minitest_reporter_plugin.rb:26:in 'Array#each'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/minitest-reporters-1.7.1/lib/minitest/minitest_reporter_plugin.rb:26:in 'Minitest::Reporters::DelegateReporter#record'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/minitest-5.25.5/lib/minitest.rb:1008:in 'block in Minitest::CompositeReporter#record'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/minitest-5.25.5/lib/minitest.rb:1007:in 'Array#each'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/minitest-5.25.5/lib/minitest.rb:1007:in 'Minitest::CompositeReporter#record'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/ci-queue-0.68.0/lib/minitest/queue.rb:192:in 'Minitest::Queue.handle_test_result'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/ci-queue-0.68.0/lib/minitest/queue.rb:164:in 'block (2 levels) in Minitest::Queue.run'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/ci-queue-0.68.0/lib/ci/queue/static.rb:98:in 'CI::Queue::Static#poll'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/ci-queue-0.68.0/lib/minitest/queue.rb:159:in 'block in Minitest::Queue.run'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/ci-queue-0.68.0/lib/minitest/queue.rb:198:in 'Minitest::Queue.rescue_run_errors'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/ci-queue-0.68.0/lib/minitest/queue.rb:158:in 'Minitest::Queue.run'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/ci-queue-0.68.0/lib/minitest/queue.rb:286:in 'Minitest::Queue#__run'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/minitest-5.25.5/lib/minitest.rb:288:in 'Minitest.run'
/Users/andrey.marchenko/p/datadog-ci-rb/spec/datadog/ci/contrib/ci_queue_minitest/instrumentation_spec.rb:31:in 'block (2 levels) in <top (required)>'
/Users/andrey.marchenko/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/rspec-core-3.13.4/lib/rspec/core/example.rb:457:in 'BasicObject#instance_exec'

It turned out that acknowledge keyword was added to the redis queue, but not static queue (I use static queue in integration tests to avoid dependency on redis). This PR fixes that and provides a unit test that covers this case.

[ChrisBr]

Thanks! Could you please sign the CLA?

[anmarchenko]

@ChrisBr how would I do that? quick search in the repo didn't help me

[ChrisBr]

how would I do that? quick search in the repo didn't help me

You should be able to sign here https://cla.shopify.com/

[anmarchenko]

Thanks, I've sent it to my team for review, will ping you when it's done

[ChrisBr]

@anmarchenko can you comment I have signed the CLA! when you've signed it. That should run the check again.

[anmarchenko]

I have signed the CLA!

[ChrisBr]

New version released in https://rubygems.org/gems/ci-queue/versions/0.69.0

Thanks