Move Minitest.__run patch internals to Minitest::Queue.run#337
Merged
Move Minitest.__run patch internals to Minitest::Queue.run#337
Minitest.__run patch internals to Minitest::Queue.run#337Conversation
casperisfine
approved these changes
Jun 16, 2025
ChrisBr
approved these changes
Jun 16, 2025
This makes it easier to confine internal methods to Minitest::Queue and avoid polluting the top-level Minitest module.
shioyama
force-pushed
the
shioyama/move_run_from_queue_to_queue_run
branch
from
68b3d55 to
5a3a595
Compare
shioyama
changed the base branch from
cbruckmayer/check-we-executed-all-tests
to
main
Member
Author
|
I rebased this on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #334
This is purely an internal refactor, to make it easier to do some things in parallel where we need parts of the patch that are not currently exposed.