Conversation
ChrisBr
commented
May 21, 2025
ChrisBr
force-pushed
the
cbruckmayer/fix-race-condition
branch
from
411093b to
649a641
Compare
Contributor
Author
|
@casperisfine rebased ♻️ |
casperisfine
approved these changes
May 21, 2025
Contributor
casperisfine
left a comment
casperisfine
left a comment
There was a problem hiding this comment.
Code look OK. Not sure about the race being fixed or not, I don't have this code in mind enough anymore.
ChrisBr
force-pushed
the
cbruckmayer/fix-race-condition
branch
from
649a641 to
8752d38
Compare
Contributor
Author
casperisfine
approved these changes
May 21, 2025
ChrisBr
force-pushed
the
cbruckmayer/fix-race-condition
branch
from
8752d38 to
7f676e5
Compare
There is a small race condition between acknowledge and recording the error in which the reporter may see the queue empty and no error recorded and wrongly thinks it's a success.
ChrisBr
force-pushed
the
cbruckmayer/fix-race-condition
branch
from
7f676e5 to
cf87aee
Compare
shelby-moore-sh
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a small race condition between acknowledge and recording the error in which the reporter may see the queue empty and no error recorded and wrongly thinks it's a success.
Follow up from #323