Error with mTLS: Certificate-Base Authentication (pysnc version 1.1.10)

[namiwa]

From the docs: https://servicenow.github.io/PySNC/user/authentication.html#mtls-mutual-tls-authentication-certificate-based-authentication

For the above certificate based authentication, it seems that auth is a required parameter of the ServiceNowClient class:

But including auth would result in the following error:

What would be the correct way to handle Certificate Based Authentication?

[namiwa]

One more point to note, in passing auth=None, like so:

It also throws the following error:

AttributeError: 'ServiceNowClient' object has no attribute '_ServiceNowClient__session'. Did you mean: '_ServiceNowClient__proxies'?

I think this bug is due to the following if block where in the case where auth is None and cert is not, the self.__session requests variable is not initialised correctly

https://github.com/ServiceNow/PySNC/blob/1.1.10/pysnc/client.py#L65

[vetsin]

This is untested code ( I never setup anything to test the mTLS for pysnc) -- I'm not terribly surprised. Try this:

auth=requests.session(), cert='dummy_cert.pem' -- it may also be cert=("client.crt", "client.key") -- the requests doc's aren't terribly clear