Skip to content

bug of lastest_readings_from_all_devices list #3

@dijkstra1930

Description

@dijkstra1930

For csv

17020003,1382624808000,null,519.0
17000008,1382624808000,null,527.0
d087d478,1382624596000,null,532.0
17a1a03d,1382623352000,null,551.0
17030009,1382624511000,null,529.0
4bd17cfe,1382624055000,null,531.0
1100e4b8,1382624189000,null,530.0
17a632b3,1382624053000,null,532.0
  • no CSV field names as first line - should be "device_id,timestamp,sensor_type,value"
  • 3rd field always "null", should be "temp" in this case, or omitted like below
  • first field sometimes the device_id (= "URI" ?), sometimes some guid?

?? is "uri"="device_id" = "id"

For json

[{"timestamp":1382625219000,"value":521,"device_id":"17010003"},{"timestamp":1382625219000,"value":519,"device_id":"17010003"}
  • here is it says "device_id",
  • does not include the "sensor_type"
  • doc says it should include sensor_type:
    {"timestamp":1368568889000,"sensor_type":"temp","value":515,"device_id":"10170204"}]

Probabaly should include the sensor_type in both cases, or "value" could be "temp" , because I could imagine a future request to retrieve a set of sensors in one call, sort of like:

This would be more consistent with other commands, like the sensor post command, which uses {"id": <"device_id">, "timestamp": <"timestamp">, <"sensor_type">: <"sensor_value">} )

[In the code we can add more than one sensor type and value in a single line, like

{"id": 17001002, "timestamp": nnnnnnn, "temp": "512", light: 10} )

This should be documented with example and corrected. It says "in json file .." it should be "json string"...

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions