Skip to content

Allow partial props for muiFieldProps in SQFormDatePickerWithDateFNS #880

@Ariel-Schnur-SQ

Description

@Ariel-Schnur-SQ

TS is yelling at me for excluding some muiFieldProps in my SQFormDatePickerWithDateFNS. Is it possible to update the type for muiFieldProps to allow partial props?

My usage:

<SQFormDatePickerWithDateFNS
      name={question.id}
      label={labelText || ''}
      onBlur={onBlur}
      muiFieldProps={{
        onAccept: onDateAccept,
        minDate: question.minValue ? new Date(question.minValue) : undefined,
        maxDate: question.maxValue ? new Date(question.maxValue) : undefined,
      }}
      isDisabled={isDisabled}
      size={4}
/>

TS error TLDR (I think): you need onChange, value, and renderInput in muiFieldProps!

Full TS error:

Type '{ onAccept: ((value: Date | null) => void) | undefined; minDate: Date | undefined; maxDate: Date | undefined; }' is not assignable to type 'MuiFieldProps<Date>'.
  Type '{ onAccept: ((value: Date | null) => void) | undefined; minDate: Date | undefined; maxDate: Date | undefined; }' is missing the following properties from type 'BaseDatePickerProps<Date, Date>': onChange, value, renderInputts(2322)
SQFormDatePickerWithDateFNS.d.ts(8, 5): The expected type comes from property 'muiFieldProps' which is declared here on type 'IntrinsicAttributes & Omit<SQFormDatePickerProps, "onChange" | "muiFieldProps"> & { onChange?: ((date: Date | null) => void) | undefined; muiFieldProps?: MuiFieldProps<Date> | undefined; }'

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions