Skip to content

Avoid conflict with Ruby's numbered parameters #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kojix2 merged 1 commit into from
Dec 27, 2025
Merged

Avoid conflict with Ruby's numbered parameters #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/iruby/backend.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def eval(code, store_history)
# TODO Add IRuby.cache_size which controls the size of the Out array
# and sets the oldest entries and _<n> variables to nil.
Copy link

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment still references the old variable naming pattern _<n>. This should be updated to _o<n> to match the new naming convention introduced in this change.

Suggested change
# and sets the oldest entries and _<n> variables to nil.
# and sets the oldest entries and _o<n> variables to nil.

Copilot uses AI. Check for mistakes.
Copy link
Member

@kojix2 kojix2 Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

if store_history
b.local_variable_set("_#{Out.size}", out)
b.local_variable_set("_o#{Out.size}", out)
b.local_variable_set("_i#{In.size}", code)

Out << out
Expand Down
Loading