Issue: Joining a world syncs player and world difficulty, overwrites world difficulty when either one is exclusively Journey mode #154
Description
Issue
When Main.ActivePlayerFileData.Player.difficulty == 3 (the selected player is in Journey Mode), the game normally prevents you from joining worlds whose gamemode doesnt match. If this restriction is removed and DragonLens is enabled, the world's gamemode syncs with the player's upon joining. When joining a non-Journey world as a journey character, the world's gamemode switches to Journey. When joining a Journey world as a non-Journey character, the world's gamemode switches to Classic, as (I believe) that is the default fallback gamemode.
What Should Happen
There shouldn't be any syncing between player and world difficulty. The world gamemode should stay as is. This issue would not appear in normal gameplay unless a mod messes with the join restrictions of vanilla difficulties, in which case the sync could potentially mess with gamemode-specific world property values.
Reproduction Steps
I removed the normal world-joining restriction with an early return in UIWorldListItem.TryMovingToRejectionMenuIfNeeded, which allowed me to play Journey worlds with non-Journey characters and vise-versa.