Some small bugs

[Bob337]

Bugs Found:

Pin Number Display Issue:

For locks with pinsStartAtZero: false, the display showed pins[i] instead of pins[i] + 1
This caused confusion - a pin value of 0 should display as "1" for standard locks

Random Generation Bug:

javascript   // Original (problematic):
   Math.floor(Math.random() * maxKeyCut - 1) + 1
   // This could produce negative values!
   
   // Fixed:
   Math.floor(Math.random() * maxKeyCut)

Navigation Boundary Issues:

selectedPinIndex could exceed valid range
Missing modulo wrap-around in some cases

Storage API Mismatch:

Original code uses storage.read() and storage.write() but these may not exist on all devices

[SasPes]

Pin Number Display Issue:

For locks with pinsStartAtZero: false, the display showed pins[i] instead of pins[i] + 1
This caused confusion - a pin value of 0 should display as "1" for standard locks

I was following Deviant Ollam -> Key Measurements. Can you please elaborate with an example?

Current version 1.13.0

Master

• pinsStartAtZero: true
• in app starts with 0
• see Deviant Ollam -> Key Measurements - Master

Kwikset

• pinsStartAtZero: false
• in app starts with 1
• see Deviant Ollam -> Key Measurements - Kwikset

---

Random Generation Bug:

javascript // Original (problematic):
Math.floor(Math.random() * maxKeyCut - 1) + 1
// This could produce negative values!

// Fixed:
Math.floor(Math.random() * maxKeyCut)

In some cases this can produce negative values.
However, this is only used for random key generation (for show), not for key decoding.

---

Navigation Boundary Issues:

selectedPinIndex could exceed valid range
Missing modulo wrap-around in some cases

Can you please elaborate?

---

Storage API Mismatch:

Original code uses storage.read() and storage.write() but these may not exist on all devices

all devices?
Currently, this app is developed and tested only for LILYGO T-Embed CC1101.
Interpreter docs for file storage operations

---

@Bob337
I'm just curious, is this generated with AI or ... ?
Btw, I have nothing against AI 😊