Several restoration recipes do not appear when Farmers Delight is not installed

[LunaLycan287]

Minecraft: 1.21.1
Neoforge 21.1.220
Malum: 1.8.2
Farmers Delight: NOT INSTALLED

Since Farmers Delight knifes are hardcoded into several restoration recipes, they do not appear for ANY item if Farmers Delight is not installed.

malum:spirit_repair/flint_restoration
malum:spirit_repair/iron_restoration
malum:spirit_repair/gold_restoration
malum:spirit_repair/diamond_restoration
malum:spirit_repair/netherite_restoration

They all hardcode the knife as follows:

  "validItems": [
    "minecraft:flint_and_steel",
    "farmersdelight:flint_knife"
  ]

Since one of the items for the recipe is not parseable the recipe will not show up at all.

Suggestions:

• Split farmersdelight content to separate compat recipes.
• Remove the farmersdelight content it should (from our understanding) be picked up by the regex in the recipe, if available
• Completely change recipe to work based on tags e.g.: malum:spirit_repair/flint. This way it would be easy for mods / modpack authors to add their own compats. (honestly we would prefer this, but understand this would probably be a bit of a rewrite)

No fixes:

Our KubeJS Fix:

ServerEvents.recipes(event => {
    event.remove('malum:spirit_repair/flint_restoration')
    event.custom({
        type: "malum:spirit_repair",
        regex: {
            itemIdRegex: "flint_.+"
        },
        repairMaterial: {
            count: 2,
            item: "minecraft:flint"
        },
        spirits: [
            {
            type: "malum:earthen",
            count: 4
            }
        ],
        validItems: [
            "minecraft:flint_and_steel"
        ]
    }).id('malum:spirit_repair/flint_restoration')
}

To identify recipe parsing errors we suggest changing log_erroring_parsed_recipes to true in /local/kubejs/dev.js