Leaves have distance 7 when loading from StructureTemplate.

[MelanX]

As the title says.

Versions

Minecraft: 1.21.1
NeoForge: 21.1.219
curios-neoforge-9.5.1+1.21.1
fastleafdecay-35
lodestone-1.21.1-1.8.2
malum-1.21.1-1.8.2
Log

How to reproduce

1. Plant a sapling
2. Let it grow
3. Use Structure Blocks to save it as StructureTemplate
4. Load that tree somewhere else using Structure Blocks
5. Wait a few minutes (or inspect Leaves) and see them disappearing because they have distance 7 now.

Alternatively, skip replace step 1 to 4 with:

1. Unzip generated.zip in your world directory.
2. Load the structure minecraft:test using a Structure Block.

How did I notice?

Someone tried to use Skyblock Builder and sent me this problem:

[...] However, when I create a island with the template all the leaves decay immediately. Is this a issue others run into? [...]

Then, I tested a bit and used vanilla mechanics to reproduce this exact behavior as described above.

[MelanX]

I think it happens because Minecraft re-computes the distances when placing a template. Adding your logs to the #minecraft:logs tag fixed the problem. In your MalumBlocks.java, you have this:

public static final DeferredHolder<Block, Block> RUNEWOOD_LOG = BLOCKS.register("runewood_log", () -> new MalumLogBlock(MalumBlockProperties.RUNEWOOD(), STRIPPED_RUNEWOOD_LOG));

Instead, you should have this:

public static final DeferredHolder<Block, Block> RUNEWOOD_LOG = BLOCKS.register("runewood_log", () -> new MalumLogBlock(MalumBlockProperties.RUNEWOOD_LOGS(), STRIPPED_RUNEWOOD_LOG));

You used the wrong block properties, not the one for logs. You should check for other log blocks as well, this one above is just an example.