Signedness of tHciIO.GetTick function pointer

[Tellicious]

As HAL_GetTick() returns an uint32_t wouldn't it be better to declare also the GetTick function pointer as unsigned? Is there a specific reason why it should be signed?

I can open a PR for this, however I'm afraid this would also need to be modified in STM32CubeMX as it creates a dedicated int32_t BSP_GetTick(void) function that returns HAL_GetTick()

x-cube-ble1/Middlewares/ST/BlueNRG-MS/hci/hci_tl_patterns/Basic/hci_tl.h

Lines 82 to 91 in 5e90a42

	typedef struct
	{
	int32_t (* Init) (void* pConf); /**< Pointer to HCI TL function for the IO Bus initialization */
	int32_t (* DeInit) (void); /**< Pointer to HCI TL function for the IO Bus de-initialization */
	int32_t (* Reset) (void); /**< Pointer to HCI TL function for the IO Bus reset */
	int32_t (* Receive) (uint8_t*, uint16_t); /**< Pointer to HCI TL function for the IO Bus data reception */
	int32_t (* Send) (uint8_t*, uint16_t); /**< Pointer to HCI TL function for the IO Bus data transmission */
	int32_t (* DataAck) (uint8_t*, uint16_t* len); /**< Pointer to HCI TL function for the IO Bus data ack reception */
	int32_t (* GetTick) (void); /**< Pointer to BSP function for getting the HAL time base timestamp */
	} tHciIO;

[silviooliva]

Hi,
indeed, before modifying the BLE1 code, the BSP_GetTick() prototype generated by the STM32CubeMX should be modified changing the return type from int32_t to uint32_t. I will try to rise this point internally.
Thank you for pointing this out.