🐛 Bug - Slow loading when viewing edited rules fetched from GitHub

[KahaMason]

Requested by: @KahaMason via YakShaver.ai 🦬
cc: @jakebayliss, @Aibono1225, @adamcogan, @joshbermanssw, @KahaMason, @Marxoz, @PothieuG, @Freego1783, @tiagov8

Hi Team!

  🟥  Watch the video (1 min 59 sec)

  Url from screen share: https://www.ssw.com.au/rules/user/author-kaha-mason

This issue is a follow-on from a previous YakShave: #2358

This previous YakShave was completed by both @Aibono1225 & @PothieuG

Pain

Users experience a long load time (~18 seconds) when viewing their edited rules in Rules V3 (TinaCMS). The page shows a 'fetching data from GitHub' loading state for an extended period before rendering the updated rules. This negatively impacts usability and indicates a potential performance issue in data fetching and/or processing.

Acceptance Criteria

1. Viewing edited rules completes loading significantly faster than current behaviour.
2. Target load time for the rules page is ≤ 5 seconds under normal conditions.
3. Loading indicator accurately reflects progress and does not block rendering longer than necessary.
4. Rules data displayed after loading is complete and accurate.
5. No regression in functionality when fetching and processing rules from GitHub.

Reproduce Steps

1. Log in to Rules V3 (TinaCMS).
2. Navigate to the list of rules you have edited.
3. Observe the 'fetching data from GitHub' loading screen.
4. Measure the time taken until all updated rules are displayed.
5. Note that the load time is approximately 18 seconds.

Screenshot

Figure: Rules page exhibits prolonged loading time

[adamcogan]

This is related to the work that Gilles did.

It is taking 18 seconds to load 🤢

#2358

-a

[Aibono1225]

The Authored Rules list fetches data (including rule content) from Tina. One reason it’s slow is that it waits for all pages to finish loading before rendering, and there’s no caching on this endpoint.

Current fix:

• Updated the page to render as soon as the first page of data is loaded, instead of waiting for all pages (PR: 2468 improve authored rules loading #2476)
• Added API caching (PR: Add caching mechanism for initial batch of rules by author #2477)

Next step:

• Check with the PO whether the current performance is acceptable