From 18b28ecdab983edfa6fb62fbfcddd74105bfaf63 Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Wed, 29 Oct 2025 09:07:49 -0500 Subject: [PATCH 01/19] first draft of adding blips --- sbncode/CAFMaker/FillBlip.cxx | 54 +++++++++++++++++++++++++++++++++++ sbncode/CAFMaker/FillBlip.h | 17 +++++++++++ 2 files changed, 71 insertions(+) create mode 100644 sbncode/CAFMaker/FillBlip.cxx create mode 100644 sbncode/CAFMaker/FillBlip.h diff --git a/sbncode/CAFMaker/FillBlip.cxx b/sbncode/CAFMaker/FillBlip.cxx new file mode 100644 index 000000000..66be0188f --- /dev/null +++ b/sbncode/CAFMaker/FillBlip.cxx @@ -0,0 +1,54 @@ +#include "sbncode/CAFMaker/FillBlip.h" + +namespace caf +{ + void FillBlip( const std::vector& LarBlips, std::vector& CAF_Blips) + { + int NBlips = LarBlips->size(); + for(int iBlip=0; iBlip= 0 ) //MC Blip + { + FillMCTruthBlip( &CurrentBlip, &NewBlip ); + } + FillBlipRealtedHitCluster( &CurrentBlip, &NewBlip ); + } + + } + + void FillMCTruthBlip( blip::Blip& LarBlip, caf::SRBlip &CAF_Blip ) + { + CAF_Blip->truthBlip = LarBlip->truthBlip; + CAF_Blip->truthBlip.Energy = CAF_Blip->truthBlip.Energy/1000.; //convert to GeV + } + + void FillBlipRealtedHitCluster(blip::Blip& LarBlip, caf::SRBlip &CAF_Blip) + { + int NumPlanes = sizeof(LarBlip->clusters)/sizeof(LarBlip->clusters[0]); + for(int iPlane=0; iPlaneclusters[iPlane] = LarBlip->clusters[iPlane] + } + } +} \ No newline at end of file diff --git a/sbncode/CAFMaker/FillBlip.h b/sbncode/CAFMaker/FillBlip.h new file mode 100644 index 000000000..501556c15 --- /dev/null +++ b/sbncode/CAFMaker/FillBlip.h @@ -0,0 +1,17 @@ +#ifndef CAF_FILLBLIP_H +#define CAF_FILLBLIP_H +#include +#include "sbnanaobj/StandardRecord/SRBlip.h" +#include "sbndcode/BlipRecoSBND/Utils/BlipUtils.h" + +#include + +namespace caf +{ + + void FillBlip( const std::vector& LarBlips, std::vector& CAF_Blips); + void FillMCTruthBlip(blip::Blip& LarBlip, caf::SRBlip& CAF_Blip ); + void FillBlipRealtedHitCluster(blip::Blip& LarBlip, caf::SRBlip& CAF_Blip); +} + +#endif From daa5c8e79ae31a364cbd216ea5a08e2a75bba917 Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Wed, 29 Oct 2025 10:35:51 -0500 Subject: [PATCH 02/19] Added blip library --- sbncode/CAFMaker/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/sbncode/CAFMaker/CMakeLists.txt b/sbncode/CAFMaker/CMakeLists.txt index aa42cba8a..fd3eeee8b 100644 --- a/sbncode/CAFMaker/CMakeLists.txt +++ b/sbncode/CAFMaker/CMakeLists.txt @@ -42,6 +42,7 @@ art_make_library( LIBRARY_NAME sbncode_CAFMaker lardataalg::DetectorInfo art::Framework_Services_System_TriggerNamesService_service sbncode_Metadata_MetadataSBN_service + sbndcode_BlipUtils larsim::Utils larevt::SpaceCharge systematicstools::interface From 8dfaab07c8935a07a392697bde67004dd159cd93 Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Wed, 29 Oct 2025 10:50:27 -0500 Subject: [PATCH 03/19] forgot to add my blip to the vector --- sbncode/CAFMaker/FillBlip.cxx | 1 + 1 file changed, 1 insertion(+) diff --git a/sbncode/CAFMaker/FillBlip.cxx b/sbncode/CAFMaker/FillBlip.cxx index 66be0188f..2ae303b5a 100644 --- a/sbncode/CAFMaker/FillBlip.cxx +++ b/sbncode/CAFMaker/FillBlip.cxx @@ -33,6 +33,7 @@ namespace caf FillMCTruthBlip( &CurrentBlip, &NewBlip ); } FillBlipRealtedHitCluster( &CurrentBlip, &NewBlip ); + CAF_Blips->push_back(NewBlip); } } From 23c5909dee7ec0a6306f96b70e9db5e19a700d02 Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Thu, 30 Oct 2025 08:53:12 -0500 Subject: [PATCH 04/19] Adding blips to cafmaker --- sbncode/CAFMaker/CAFMaker_module.cc | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sbncode/CAFMaker/CAFMaker_module.cc b/sbncode/CAFMaker/CAFMaker_module.cc index 7baf6ef0c..ae0b9ca8c 100644 --- a/sbncode/CAFMaker/CAFMaker_module.cc +++ b/sbncode/CAFMaker/CAFMaker_module.cc @@ -20,6 +20,7 @@ #include "sbncode/CAFMaker/FillExposure.h" #include "sbncode/CAFMaker/FillTrigger.h" #include "sbncode/CAFMaker/Utils.h" +#include "sbncode/CAFMaker/FillBlip.h" // C/C++ includes #include @@ -1874,6 +1875,13 @@ void CAFMaker::produce(art::Event& evt) noexcept { } } + //Fill blips. art::handle for blips and then call fill blips for each one. Make a vector to hold all of them. I handle for loop in Fill blip + art::Handle> blipHandle; + std::vector> srblips; + if(evt.GetByLabel( fBlipTag, blipHandle)) //fill SR blips + { + FillBlip( (*LarBlips) , srblips); + } // collect the TPC slices std::vector> slices; std::vector slice_tag_suffixes; @@ -2543,6 +2551,7 @@ void CAFMaker::produce(art::Event& evt) noexcept { rec.nsbnd_crt_tracks = srsbndcrttracks.size(); rec.opflashes = srflashes; rec.nopflashes = srflashes.size(); + rec.blips = srblips; rec.sbnd_frames = srsbndframeshiftinfo; rec.sbnd_timings = srsbndtiminginfo; From 3812b043518cbcc168ee229e671bd0fa85672d55 Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Mon, 10 Nov 2025 15:26:58 -0600 Subject: [PATCH 05/19] added blips to cafmaker --- sbncode/CAFMaker/CAFMakerParams.h | 4 ++ sbncode/CAFMaker/CAFMaker_module.cc | 12 +++-- sbncode/CAFMaker/CMakeLists.txt | 1 + sbncode/CAFMaker/FillBlip.cxx | 69 ++++++++++++++++++++++++----- 4 files changed, 73 insertions(+), 13 deletions(-) diff --git a/sbncode/CAFMaker/CAFMakerParams.h b/sbncode/CAFMaker/CAFMakerParams.h index 4fc80a207..ce9bfd20f 100644 --- a/sbncode/CAFMaker/CAFMakerParams.h +++ b/sbncode/CAFMaker/CAFMakerParams.h @@ -622,6 +622,10 @@ namespace caf Comment("Label of CVN scores."), "cvn" }; + Atom fBlipTag { Name("BlipTag"), + Comment("Provide a string to label the blip input"), "reco2:Blip:BlipReco" + }; + }; } diff --git a/sbncode/CAFMaker/CAFMaker_module.cc b/sbncode/CAFMaker/CAFMaker_module.cc index 2cf0b9084..b822e7910 100644 --- a/sbncode/CAFMaker/CAFMaker_module.cc +++ b/sbncode/CAFMaker/CAFMaker_module.cc @@ -284,6 +284,7 @@ class CAFMaker : public art::EDProducer { int fGenieEvtRec_brStdHepLd [250] = {0}; ////< Last daughter int fGenieEvtRec_brStdHepFm [250] = {0}; ////< First mother int fGenieEvtRec_brStdHepLm [250] = {0}; ////< Last mother + //std::string fBlipTag; flat::Flat* fFlatRecord = 0; flat::Flat* fFlatRecordb = 0; @@ -1919,10 +1920,15 @@ void CAFMaker::produce(art::Event& evt) noexcept { //Fill blips. art::handle for blips and then call fill blips for each one. Make a vector to hold all of them. I handle for loop in Fill blip art::Handle> blipHandle; - std::vector> srblips; - if(evt.GetByLabel( fBlipTag, blipHandle)) //fill SR blips + std::vector srblips; + if(evt.getByLabel( fParams.fBlipTag(), blipHandle)) //fill SR blips { - FillBlip( (*LarBlips) , srblips); + FillBlip( (*blipHandle), srblips); + //for(int i=0; isize()); i++) + // { + // auto LarBlips = (*(blipHandle))[i]; + // FillBlip( (LarBlips) , srblips); + // } } // collect the TPC slices std::vector> slices; diff --git a/sbncode/CAFMaker/CMakeLists.txt b/sbncode/CAFMaker/CMakeLists.txt index fd3eeee8b..ff0411e46 100644 --- a/sbncode/CAFMaker/CMakeLists.txt +++ b/sbncode/CAFMaker/CMakeLists.txt @@ -39,6 +39,7 @@ art_make_library( LIBRARY_NAME sbncode_CAFMaker sbnobj::Common_Trigger sbnobj::SBND_CRT sbnobj::SBND_Timing + sbndobj_BlipDataTypes lardataalg::DetectorInfo art::Framework_Services_System_TriggerNamesService_service sbncode_Metadata_MetadataSBN_service diff --git a/sbncode/CAFMaker/FillBlip.cxx b/sbncode/CAFMaker/FillBlip.cxx index 2ae303b5a..fa300f743 100644 --- a/sbncode/CAFMaker/FillBlip.cxx +++ b/sbncode/CAFMaker/FillBlip.cxx @@ -4,7 +4,7 @@ namespace caf { void FillBlip( const std::vector& LarBlips, std::vector& CAF_Blips) { - int NBlips = LarBlips->size(); + int NBlips = LarBlips.size(); for(int iBlip=0; iBlip= 0 ) //MC Blip + if(CurrentBlip.truth.ID >= 0 ) //MC Blip { - FillMCTruthBlip( &CurrentBlip, &NewBlip ); + FillMCTruthBlip( CurrentBlip, NewBlip ); } - FillBlipRealtedHitCluster( &CurrentBlip, &NewBlip ); - CAF_Blips->push_back(NewBlip); + FillBlipRealtedHitCluster( CurrentBlip, NewBlip ); + CAF_Blips.push_back(NewBlip); } } void FillMCTruthBlip( blip::Blip& LarBlip, caf::SRBlip &CAF_Blip ) { - CAF_Blip->truthBlip = LarBlip->truthBlip; - CAF_Blip->truthBlip.Energy = CAF_Blip->truthBlip.Energy/1000.; //convert to GeV + //CAF_Blip.truthBlip = LarBlip.truth; + CAF_Blip.truthBlip.ID = LarBlip.truth.ID; + CAF_Blip.truthBlip.Cryostat =LarBlip.truth.Cryostat; + CAF_Blip.truthBlip.TPC =LarBlip.truth.TPC; + CAF_Blip.truthBlip.Time =LarBlip.truth.Time; + CAF_Blip.truthBlip.TimeTick =LarBlip.truth.TimeTick; + CAF_Blip.truthBlip.DriftTime =LarBlip.truth.DriftTime; + CAF_Blip.truthBlip.Energy =LarBlip.truth.Energy; + CAF_Blip.truthBlip.DepElectrons =LarBlip.truth.DepElectrons; + CAF_Blip.truthBlip.NumElectrons =LarBlip.truth.NumElectrons; + CAF_Blip.truthBlip.LeadG4ID =LarBlip.truth.LeadG4ID; + CAF_Blip.truthBlip.LeadG4Index =LarBlip.truth.LeadG4Index; + CAF_Blip.truthBlip.LeadG4PDG =LarBlip.truth.LeadG4PDG; + CAF_Blip.truthBlip.LeadCharge =LarBlip.truth.LeadCharge; + CAF_Blip.truthBlip.Position =LarBlip.truth.Position; + CAF_Blip.truthBlip.Energy = CAF_Blip.truthBlip.Energy/1000.; //convert to GeV } void FillBlipRealtedHitCluster(blip::Blip& LarBlip, caf::SRBlip &CAF_Blip) { - int NumPlanes = sizeof(LarBlip->clusters)/sizeof(LarBlip->clusters[0]); + int NumPlanes = sizeof(LarBlip.clusters)/sizeof(LarBlip.clusters[0]); for(int iPlane=0; iPlaneclusters[iPlane] = LarBlip->clusters[iPlane] + CAF_Blip.clusters[iPlane].ID = LarBlip.clusters[iPlane].ID; + CAF_Blip.clusters[iPlane].isValid = LarBlip.clusters[iPlane].isValid; + CAF_Blip.clusters[iPlane].CenterChan = LarBlip.clusters[iPlane].CenterChan; + CAF_Blip.clusters[iPlane].CenterWire = LarBlip.clusters[iPlane].CenterWire; + CAF_Blip.clusters[iPlane].isTruthMatched = LarBlip.clusters[iPlane].isTruthMatched; + CAF_Blip.clusters[iPlane].isMerged = LarBlip.clusters[iPlane].isMerged; + CAF_Blip.clusters[iPlane].isMatched = LarBlip.clusters[iPlane].isMatched; + CAF_Blip.clusters[iPlane].DeadWireSep = LarBlip.clusters[iPlane].DeadWireSep; + CAF_Blip.clusters[iPlane].Cryostat = LarBlip.clusters[iPlane].Cryostat; + CAF_Blip.clusters[iPlane].TPC = LarBlip.clusters[iPlane].TPC; + CAF_Blip.clusters[iPlane].Plane = LarBlip.clusters[iPlane].Plane; + CAF_Blip.clusters[iPlane].NHits = LarBlip.clusters[iPlane].NHits; + CAF_Blip.clusters[iPlane].NWires = LarBlip.clusters[iPlane].NWires; + CAF_Blip.clusters[iPlane].ADCs = LarBlip.clusters[iPlane].ADCs; + CAF_Blip.clusters[iPlane].Amplitude = LarBlip.clusters[iPlane].Amplitude; + CAF_Blip.clusters[iPlane].Charge = LarBlip.clusters[iPlane].Charge; + CAF_Blip.clusters[iPlane].SigmaCharge = LarBlip.clusters[iPlane].SigmaCharge; + CAF_Blip.clusters[iPlane].TimeTick = LarBlip.clusters[iPlane].TimeTick; + CAF_Blip.clusters[iPlane].Time = LarBlip.clusters[iPlane].Time; + CAF_Blip.clusters[iPlane].StartHitTime = LarBlip.clusters[iPlane].StartHitTime; + CAF_Blip.clusters[iPlane].EndHitTime = LarBlip.clusters[iPlane].EndHitTime; + CAF_Blip.clusters[iPlane].StartTime = LarBlip.clusters[iPlane].StartTime; + CAF_Blip.clusters[iPlane].EndTime = LarBlip.clusters[iPlane].EndTime; + CAF_Blip.clusters[iPlane].Timespan = LarBlip.clusters[iPlane].Timespan; + CAF_Blip.clusters[iPlane].RMS = LarBlip.clusters[iPlane].RMS; + CAF_Blip.clusters[iPlane].StartWire = LarBlip.clusters[iPlane].StartWire; + CAF_Blip.clusters[iPlane].EndWire = LarBlip.clusters[iPlane].EndWire; + CAF_Blip.clusters[iPlane].NPulseTrainHits = LarBlip.clusters[iPlane].NPulseTrainHits; + CAF_Blip.clusters[iPlane].GoodnessOfFit = LarBlip.clusters[iPlane].GoodnessOfFit; + CAF_Blip.clusters[iPlane].BlipID = LarBlip.clusters[iPlane].BlipID; + CAF_Blip.clusters[iPlane].EdepID = LarBlip.clusters[iPlane].EdepID; + //These are sets that need to become vectors so we need to do some loops + for(auto HitID : LarBlip.clusters[iPlane].HitIDs) CAF_Blip.clusters[iPlane].HitIDs.push_back(HitID); + for(auto Wire : LarBlip.clusters[iPlane].Wires) CAF_Blip.clusters[iPlane].Wires.push_back(Wire); + for(auto Chan : LarBlip.clusters[iPlane].Chans) CAF_Blip.clusters[iPlane].Chans.push_back(Chan); + for(auto G4ID : LarBlip.clusters[iPlane].G4IDs) CAF_Blip.clusters[iPlane].G4IDs.push_back(G4ID); } } -} \ No newline at end of file +} From e4cc10e116b0e28a3ff969bbc11486d41a2ff61a Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Thu, 13 Nov 2025 16:47:45 -0600 Subject: [PATCH 06/19] mistake in the cmakelist --- sbncode/CAFMaker/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbncode/CAFMaker/CMakeLists.txt b/sbncode/CAFMaker/CMakeLists.txt index ff0411e46..b9ddd40f9 100644 --- a/sbncode/CAFMaker/CMakeLists.txt +++ b/sbncode/CAFMaker/CMakeLists.txt @@ -43,7 +43,7 @@ art_make_library( LIBRARY_NAME sbncode_CAFMaker lardataalg::DetectorInfo art::Framework_Services_System_TriggerNamesService_service sbncode_Metadata_MetadataSBN_service - sbndcode_BlipUtils + #sbndcode_BlipUtils larsim::Utils larevt::SpaceCharge systematicstools::interface From 0c6241963733b6cbe6000270f60a0181f4881111 Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Thu, 13 Nov 2025 17:13:41 -0600 Subject: [PATCH 07/19] Updating include --- sbncode/CAFMaker/FillBlip.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbncode/CAFMaker/FillBlip.h b/sbncode/CAFMaker/FillBlip.h index 501556c15..d08e0d5e7 100644 --- a/sbncode/CAFMaker/FillBlip.h +++ b/sbncode/CAFMaker/FillBlip.h @@ -2,7 +2,7 @@ #define CAF_FILLBLIP_H #include #include "sbnanaobj/StandardRecord/SRBlip.h" -#include "sbndcode/BlipRecoSBND/Utils/BlipUtils.h" +#include "sbnobj/SBND/Blip/BlipDataTypes.h" #include From 97b9db8c5bb10304ca4646126eb77ddf50b8af29 Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Thu, 20 Nov 2025 08:57:36 -0600 Subject: [PATCH 08/19] Fixing comments that aren't tabs --- sbncode/CAFMaker/CAFMakerParams.h | 2 +- sbncode/CAFMaker/CAFMaker_module.cc | 1 - sbncode/CAFMaker/FillBlip.cxx | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/sbncode/CAFMaker/CAFMakerParams.h b/sbncode/CAFMaker/CAFMakerParams.h index ce9bfd20f..e69e50208 100644 --- a/sbncode/CAFMaker/CAFMakerParams.h +++ b/sbncode/CAFMaker/CAFMakerParams.h @@ -623,7 +623,7 @@ namespace caf "cvn" }; Atom fBlipTag { Name("BlipTag"), - Comment("Provide a string to label the blip input"), "reco2:Blip:BlipReco" + Comment("Provide a string to label the blip input"), "blipreco" }; diff --git a/sbncode/CAFMaker/CAFMaker_module.cc b/sbncode/CAFMaker/CAFMaker_module.cc index b822e7910..09cb0e205 100644 --- a/sbncode/CAFMaker/CAFMaker_module.cc +++ b/sbncode/CAFMaker/CAFMaker_module.cc @@ -284,7 +284,6 @@ class CAFMaker : public art::EDProducer { int fGenieEvtRec_brStdHepLd [250] = {0}; ////< Last daughter int fGenieEvtRec_brStdHepFm [250] = {0}; ////< First mother int fGenieEvtRec_brStdHepLm [250] = {0}; ////< Last mother - //std::string fBlipTag; flat::Flat* fFlatRecord = 0; flat::Flat* fFlatRecordb = 0; diff --git a/sbncode/CAFMaker/FillBlip.cxx b/sbncode/CAFMaker/FillBlip.cxx index fa300f743..8857a060d 100644 --- a/sbncode/CAFMaker/FillBlip.cxx +++ b/sbncode/CAFMaker/FillBlip.cxx @@ -55,7 +55,7 @@ namespace caf CAF_Blip.truthBlip.LeadG4PDG =LarBlip.truth.LeadG4PDG; CAF_Blip.truthBlip.LeadCharge =LarBlip.truth.LeadCharge; CAF_Blip.truthBlip.Position =LarBlip.truth.Position; - CAF_Blip.truthBlip.Energy = CAF_Blip.truthBlip.Energy/1000.; //convert to GeV + CAF_Blip.truthBlip.Energy = CAF_Blip.truthBlip.Energy/1000.; //convert to GeV } void FillBlipRealtedHitCluster(blip::Blip& LarBlip, caf::SRBlip &CAF_Blip) @@ -69,7 +69,7 @@ namespace caf CAF_Blip.clusters[iPlane].CenterWire = LarBlip.clusters[iPlane].CenterWire; CAF_Blip.clusters[iPlane].isTruthMatched = LarBlip.clusters[iPlane].isTruthMatched; CAF_Blip.clusters[iPlane].isMerged = LarBlip.clusters[iPlane].isMerged; - CAF_Blip.clusters[iPlane].isMatched = LarBlip.clusters[iPlane].isMatched; + CAF_Blip.clusters[iPlane].isMatched = LarBlip.clusters[iPlane].isMatched; CAF_Blip.clusters[iPlane].DeadWireSep = LarBlip.clusters[iPlane].DeadWireSep; CAF_Blip.clusters[iPlane].Cryostat = LarBlip.clusters[iPlane].Cryostat; CAF_Blip.clusters[iPlane].TPC = LarBlip.clusters[iPlane].TPC; From 44e03a47610b9f31c2eeff75094e2d3bad7cb140 Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Thu, 20 Nov 2025 09:55:23 -0600 Subject: [PATCH 09/19] Fixing indentation --- sbncode/CAFMaker/FillBlip.cxx | 72 +++++++++++++++++------------------ 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/sbncode/CAFMaker/FillBlip.cxx b/sbncode/CAFMaker/FillBlip.cxx index 8857a060d..44b734b9e 100644 --- a/sbncode/CAFMaker/FillBlip.cxx +++ b/sbncode/CAFMaker/FillBlip.cxx @@ -63,42 +63,42 @@ namespace caf int NumPlanes = sizeof(LarBlip.clusters)/sizeof(LarBlip.clusters[0]); for(int iPlane=0; iPlane Date: Sat, 29 Nov 2025 12:54:57 -0600 Subject: [PATCH 10/19] part of general tvector3 replacement --- sbncode/CAFMaker/FillBlip.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sbncode/CAFMaker/FillBlip.cxx b/sbncode/CAFMaker/FillBlip.cxx index 44b734b9e..636264312 100644 --- a/sbncode/CAFMaker/FillBlip.cxx +++ b/sbncode/CAFMaker/FillBlip.cxx @@ -24,7 +24,7 @@ namespace caf NewBlip.ProxTrkDist = CurrentBlip.ProxTrkDist; NewBlip.ProxTrkID = CurrentBlip.ProxTrkID; NewBlip.inCylinder = CurrentBlip.inCylinder; - NewBlip.Position = CurrentBlip.Position; + NewBlip.Position.SetXYZ(CurrentBlip.Position.X(), CurrentBlip.Position.Y(), CurrentBlip.Position.Z()); NewBlip.SigmaYZ = CurrentBlip.SigmaYZ; NewBlip.dX = CurrentBlip.dX; NewBlip.dYZ = CurrentBlip.dYZ; @@ -54,7 +54,7 @@ namespace caf CAF_Blip.truthBlip.LeadG4Index =LarBlip.truth.LeadG4Index; CAF_Blip.truthBlip.LeadG4PDG =LarBlip.truth.LeadG4PDG; CAF_Blip.truthBlip.LeadCharge =LarBlip.truth.LeadCharge; - CAF_Blip.truthBlip.Position =LarBlip.truth.Position; + CAF_Blip.truthBlip.Position.SetXYZ(LarBlip.truth.Position.X(), LarBlip.truth.Position.Y(), LarBlip.truth.Position.Z()); CAF_Blip.truthBlip.Energy = CAF_Blip.truthBlip.Energy/1000.; //convert to GeV } From b6b0f4fef9bed535581361842d7f18e95e11e73e Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Sat, 29 Nov 2025 13:07:41 -0600 Subject: [PATCH 11/19] Missed one cmake list update --- sbncode/CAFMaker/CMakeLists.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sbncode/CAFMaker/CMakeLists.txt b/sbncode/CAFMaker/CMakeLists.txt index b9ddd40f9..820e43fbc 100644 --- a/sbncode/CAFMaker/CMakeLists.txt +++ b/sbncode/CAFMaker/CMakeLists.txt @@ -39,11 +39,10 @@ art_make_library( LIBRARY_NAME sbncode_CAFMaker sbnobj::Common_Trigger sbnobj::SBND_CRT sbnobj::SBND_Timing - sbndobj_BlipDataTypes + sbnobj::SBND_Blip lardataalg::DetectorInfo art::Framework_Services_System_TriggerNamesService_service sbncode_Metadata_MetadataSBN_service - #sbndcode_BlipUtils larsim::Utils larevt::SpaceCharge systematicstools::interface From ddda71aeea6af98e115a53878f1acde75a7f9e3b Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Sun, 30 Nov 2025 16:32:01 -0600 Subject: [PATCH 12/19] Adjusting fillBlip to account for removed variables --- sbncode/CAFMaker/FillBlip.cxx | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sbncode/CAFMaker/FillBlip.cxx b/sbncode/CAFMaker/FillBlip.cxx index 636264312..4f56c945a 100644 --- a/sbncode/CAFMaker/FillBlip.cxx +++ b/sbncode/CAFMaker/FillBlip.cxx @@ -40,12 +40,10 @@ namespace caf void FillMCTruthBlip( blip::Blip& LarBlip, caf::SRBlip &CAF_Blip ) { - //CAF_Blip.truthBlip = LarBlip.truth; CAF_Blip.truthBlip.ID = LarBlip.truth.ID; CAF_Blip.truthBlip.Cryostat =LarBlip.truth.Cryostat; CAF_Blip.truthBlip.TPC =LarBlip.truth.TPC; CAF_Blip.truthBlip.Time =LarBlip.truth.Time; - CAF_Blip.truthBlip.TimeTick =LarBlip.truth.TimeTick; CAF_Blip.truthBlip.DriftTime =LarBlip.truth.DriftTime; CAF_Blip.truthBlip.Energy =LarBlip.truth.Energy; CAF_Blip.truthBlip.DepElectrons =LarBlip.truth.DepElectrons; @@ -68,7 +66,6 @@ namespace caf CAF_Blip.clusters[iPlane].CenterChan = LarBlip.clusters[iPlane].CenterChan; CAF_Blip.clusters[iPlane].CenterWire = LarBlip.clusters[iPlane].CenterWire; CAF_Blip.clusters[iPlane].isTruthMatched = LarBlip.clusters[iPlane].isTruthMatched; - CAF_Blip.clusters[iPlane].isMerged = LarBlip.clusters[iPlane].isMerged; CAF_Blip.clusters[iPlane].isMatched = LarBlip.clusters[iPlane].isMatched; CAF_Blip.clusters[iPlane].DeadWireSep = LarBlip.clusters[iPlane].DeadWireSep; CAF_Blip.clusters[iPlane].Cryostat = LarBlip.clusters[iPlane].Cryostat; @@ -82,8 +79,6 @@ namespace caf CAF_Blip.clusters[iPlane].SigmaCharge = LarBlip.clusters[iPlane].SigmaCharge; CAF_Blip.clusters[iPlane].TimeTick = LarBlip.clusters[iPlane].TimeTick; CAF_Blip.clusters[iPlane].Time = LarBlip.clusters[iPlane].Time; - CAF_Blip.clusters[iPlane].StartHitTime = LarBlip.clusters[iPlane].StartHitTime; - CAF_Blip.clusters[iPlane].EndHitTime = LarBlip.clusters[iPlane].EndHitTime; CAF_Blip.clusters[iPlane].StartTime = LarBlip.clusters[iPlane].StartTime; CAF_Blip.clusters[iPlane].EndTime = LarBlip.clusters[iPlane].EndTime; CAF_Blip.clusters[iPlane].Timespan = LarBlip.clusters[iPlane].Timespan; From 05878a398c6e87d3422d8b0fba702f64eaf1025c Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Sun, 30 Nov 2025 17:20:37 -0600 Subject: [PATCH 13/19] change to camelcase --- sbncode/CAFMaker/FillBlip.cxx | 98 +++++++++++++++++------------------ 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/sbncode/CAFMaker/FillBlip.cxx b/sbncode/CAFMaker/FillBlip.cxx index 4f56c945a..30194b19b 100644 --- a/sbncode/CAFMaker/FillBlip.cxx +++ b/sbncode/CAFMaker/FillBlip.cxx @@ -11,21 +11,21 @@ namespace caf caf::SRBlip NewBlip; NewBlip.ID = CurrentBlip.ID; NewBlip.isValid = CurrentBlip.isValid; - NewBlip.Cryostat = CurrentBlip.Cryostat; + NewBlip.cryostat = CurrentBlip.Cryostat; NewBlip.TPC = CurrentBlip.TPC; - NewBlip.NPlanes = CurrentBlip.NPlanes; - NewBlip.MaxWireSpan = CurrentBlip.MaxWireSpan; - NewBlip.TimeTick = CurrentBlip.TimeTick; - NewBlip.Time = CurrentBlip.Time; - NewBlip.Charge = CurrentBlip.Charge; - NewBlip.Energy = CurrentBlip.Energy/1000.; //convert to GeV - NewBlip.EnergyESTAR = CurrentBlip.EnergyESTAR/1000.; //convert to GeV - NewBlip.EnergyPSTAR = CurrentBlip.EnergyPSTAR/1000.; //convert to GeV - NewBlip.ProxTrkDist = CurrentBlip.ProxTrkDist; - NewBlip.ProxTrkID = CurrentBlip.ProxTrkID; + NewBlip.nPlanes = CurrentBlip.NPlanes; + NewBlip.maxWireSpan = CurrentBlip.MaxWireSpan; + NewBlip.timeTick = CurrentBlip.TimeTick; + NewBlip.time = CurrentBlip.Time; + NewBlip.charge = CurrentBlip.Charge; + NewBlip.energy = CurrentBlip.Energy/1000.; //convert to GeV + NewBlip.energyESTAR = CurrentBlip.EnergyESTAR/1000.; //convert to GeV + NewBlip.energyPSTAR = CurrentBlip.EnergyPSTAR/1000.; //convert to GeV + NewBlip.proxTrkDist = CurrentBlip.ProxTrkDist; + NewBlip.proxTrkID = CurrentBlip.ProxTrkID; NewBlip.inCylinder = CurrentBlip.inCylinder; - NewBlip.Position.SetXYZ(CurrentBlip.Position.X(), CurrentBlip.Position.Y(), CurrentBlip.Position.Z()); - NewBlip.SigmaYZ = CurrentBlip.SigmaYZ; + NewBlip.position.SetXYZ(CurrentBlip.Position.X(), CurrentBlip.Position.Y(), CurrentBlip.Position.Z()); + NewBlip.sigmaYZ = CurrentBlip.SigmaYZ; NewBlip.dX = CurrentBlip.dX; NewBlip.dYZ = CurrentBlip.dYZ; if(CurrentBlip.truth.ID >= 0 ) //MC Blip @@ -41,19 +41,19 @@ namespace caf void FillMCTruthBlip( blip::Blip& LarBlip, caf::SRBlip &CAF_Blip ) { CAF_Blip.truthBlip.ID = LarBlip.truth.ID; - CAF_Blip.truthBlip.Cryostat =LarBlip.truth.Cryostat; + CAF_Blip.truthBlip.cryostat =LarBlip.truth.Cryostat; CAF_Blip.truthBlip.TPC =LarBlip.truth.TPC; - CAF_Blip.truthBlip.Time =LarBlip.truth.Time; - CAF_Blip.truthBlip.DriftTime =LarBlip.truth.DriftTime; - CAF_Blip.truthBlip.Energy =LarBlip.truth.Energy; - CAF_Blip.truthBlip.DepElectrons =LarBlip.truth.DepElectrons; - CAF_Blip.truthBlip.NumElectrons =LarBlip.truth.NumElectrons; - CAF_Blip.truthBlip.LeadG4ID =LarBlip.truth.LeadG4ID; - CAF_Blip.truthBlip.LeadG4Index =LarBlip.truth.LeadG4Index; - CAF_Blip.truthBlip.LeadG4PDG =LarBlip.truth.LeadG4PDG; - CAF_Blip.truthBlip.LeadCharge =LarBlip.truth.LeadCharge; - CAF_Blip.truthBlip.Position.SetXYZ(LarBlip.truth.Position.X(), LarBlip.truth.Position.Y(), LarBlip.truth.Position.Z()); - CAF_Blip.truthBlip.Energy = CAF_Blip.truthBlip.Energy/1000.; //convert to GeV + CAF_Blip.truthBlip.time =LarBlip.truth.Time; + CAF_Blip.truthBlip.driftTime =LarBlip.truth.DriftTime; + CAF_Blip.truthBlip.energy =LarBlip.truth.Energy; + CAF_Blip.truthBlip.depElectrons =LarBlip.truth.DepElectrons; + CAF_Blip.truthBlip.numElectrons =LarBlip.truth.NumElectrons; + CAF_Blip.truthBlip.leadG4ID =LarBlip.truth.LeadG4ID; + CAF_Blip.truthBlip.leadG4Index =LarBlip.truth.LeadG4Index; + CAF_Blip.truthBlip.leadG4PDG =LarBlip.truth.LeadG4PDG; + CAF_Blip.truthBlip.leadCharge =LarBlip.truth.LeadCharge; + CAF_Blip.truthBlip.position.SetXYZ(LarBlip.truth.Position.X(), LarBlip.truth.Position.Y(), LarBlip.truth.Position.Z()); + CAF_Blip.truthBlip.energy = CAF_Blip.truthBlip.energy/1000.; //convert to GeV } void FillBlipRealtedHitCluster(blip::Blip& LarBlip, caf::SRBlip &CAF_Blip) @@ -63,36 +63,36 @@ namespace caf { CAF_Blip.clusters[iPlane].ID = LarBlip.clusters[iPlane].ID; CAF_Blip.clusters[iPlane].isValid = LarBlip.clusters[iPlane].isValid; - CAF_Blip.clusters[iPlane].CenterChan = LarBlip.clusters[iPlane].CenterChan; - CAF_Blip.clusters[iPlane].CenterWire = LarBlip.clusters[iPlane].CenterWire; + CAF_Blip.clusters[iPlane].centerChan = LarBlip.clusters[iPlane].CenterChan; + CAF_Blip.clusters[iPlane].centerWire = LarBlip.clusters[iPlane].CenterWire; CAF_Blip.clusters[iPlane].isTruthMatched = LarBlip.clusters[iPlane].isTruthMatched; CAF_Blip.clusters[iPlane].isMatched = LarBlip.clusters[iPlane].isMatched; - CAF_Blip.clusters[iPlane].DeadWireSep = LarBlip.clusters[iPlane].DeadWireSep; - CAF_Blip.clusters[iPlane].Cryostat = LarBlip.clusters[iPlane].Cryostat; + CAF_Blip.clusters[iPlane].deadWireSep = LarBlip.clusters[iPlane].DeadWireSep; + CAF_Blip.clusters[iPlane].cryostat = LarBlip.clusters[iPlane].Cryostat; CAF_Blip.clusters[iPlane].TPC = LarBlip.clusters[iPlane].TPC; - CAF_Blip.clusters[iPlane].Plane = LarBlip.clusters[iPlane].Plane; - CAF_Blip.clusters[iPlane].NHits = LarBlip.clusters[iPlane].NHits; - CAF_Blip.clusters[iPlane].NWires = LarBlip.clusters[iPlane].NWires; + CAF_Blip.clusters[iPlane].plane = LarBlip.clusters[iPlane].Plane; + CAF_Blip.clusters[iPlane].nHits = LarBlip.clusters[iPlane].NHits; + CAF_Blip.clusters[iPlane].nWires = LarBlip.clusters[iPlane].NWires; CAF_Blip.clusters[iPlane].ADCs = LarBlip.clusters[iPlane].ADCs; - CAF_Blip.clusters[iPlane].Amplitude = LarBlip.clusters[iPlane].Amplitude; - CAF_Blip.clusters[iPlane].Charge = LarBlip.clusters[iPlane].Charge; - CAF_Blip.clusters[iPlane].SigmaCharge = LarBlip.clusters[iPlane].SigmaCharge; - CAF_Blip.clusters[iPlane].TimeTick = LarBlip.clusters[iPlane].TimeTick; - CAF_Blip.clusters[iPlane].Time = LarBlip.clusters[iPlane].Time; - CAF_Blip.clusters[iPlane].StartTime = LarBlip.clusters[iPlane].StartTime; - CAF_Blip.clusters[iPlane].EndTime = LarBlip.clusters[iPlane].EndTime; - CAF_Blip.clusters[iPlane].Timespan = LarBlip.clusters[iPlane].Timespan; + CAF_Blip.clusters[iPlane].amplitude = LarBlip.clusters[iPlane].Amplitude; + CAF_Blip.clusters[iPlane].charge = LarBlip.clusters[iPlane].Charge; + CAF_Blip.clusters[iPlane].sigmaCharge = LarBlip.clusters[iPlane].SigmaCharge; + CAF_Blip.clusters[iPlane].timeTick = LarBlip.clusters[iPlane].TimeTick; + CAF_Blip.clusters[iPlane].time = LarBlip.clusters[iPlane].Time; + CAF_Blip.clusters[iPlane].startTime = LarBlip.clusters[iPlane].StartTime; + CAF_Blip.clusters[iPlane].endTime = LarBlip.clusters[iPlane].EndTime; + CAF_Blip.clusters[iPlane].timespan = LarBlip.clusters[iPlane].Timespan; CAF_Blip.clusters[iPlane].RMS = LarBlip.clusters[iPlane].RMS; - CAF_Blip.clusters[iPlane].StartWire = LarBlip.clusters[iPlane].StartWire; - CAF_Blip.clusters[iPlane].EndWire = LarBlip.clusters[iPlane].EndWire; - CAF_Blip.clusters[iPlane].NPulseTrainHits = LarBlip.clusters[iPlane].NPulseTrainHits; - CAF_Blip.clusters[iPlane].GoodnessOfFit = LarBlip.clusters[iPlane].GoodnessOfFit; - CAF_Blip.clusters[iPlane].BlipID = LarBlip.clusters[iPlane].BlipID; - CAF_Blip.clusters[iPlane].EdepID = LarBlip.clusters[iPlane].EdepID; + CAF_Blip.clusters[iPlane].startWire = LarBlip.clusters[iPlane].StartWire; + CAF_Blip.clusters[iPlane].endWire = LarBlip.clusters[iPlane].EndWire; + CAF_Blip.clusters[iPlane].nPulseTrainHits = LarBlip.clusters[iPlane].NPulseTrainHits; + CAF_Blip.clusters[iPlane].goodnessOfFit = LarBlip.clusters[iPlane].GoodnessOfFit; + CAF_Blip.clusters[iPlane].blipID = LarBlip.clusters[iPlane].BlipID; + CAF_Blip.clusters[iPlane].edepID = LarBlip.clusters[iPlane].EdepID; //These are sets that need to become vectors so we need to do some loops - for(auto HitID : LarBlip.clusters[iPlane].HitIDs) CAF_Blip.clusters[iPlane].HitIDs.push_back(HitID); - for(auto Wire : LarBlip.clusters[iPlane].Wires) CAF_Blip.clusters[iPlane].Wires.push_back(Wire); - for(auto Chan : LarBlip.clusters[iPlane].Chans) CAF_Blip.clusters[iPlane].Chans.push_back(Chan); + for(auto HitID : LarBlip.clusters[iPlane].HitIDs) CAF_Blip.clusters[iPlane].hitIDs.push_back(HitID); + for(auto Wire : LarBlip.clusters[iPlane].Wires) CAF_Blip.clusters[iPlane].wires.push_back(Wire); + for(auto Chan : LarBlip.clusters[iPlane].Chans) CAF_Blip.clusters[iPlane].chans.push_back(Chan); for(auto G4ID : LarBlip.clusters[iPlane].G4IDs) CAF_Blip.clusters[iPlane].G4IDs.push_back(G4ID); } } From fe6e4101b3db960d6d268ee418403ea9e4a5a0d8 Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Mon, 15 Dec 2025 16:10:52 -0600 Subject: [PATCH 14/19] Removed old code --- sbncode/CAFMaker/CAFMaker_module.cc | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sbncode/CAFMaker/CAFMaker_module.cc b/sbncode/CAFMaker/CAFMaker_module.cc index 8e9fced83..86efb71b8 100644 --- a/sbncode/CAFMaker/CAFMaker_module.cc +++ b/sbncode/CAFMaker/CAFMaker_module.cc @@ -1935,11 +1935,6 @@ void CAFMaker::produce(art::Event& evt) noexcept { if(evt.getByLabel( fParams.fBlipTag(), blipHandle)) //fill SR blips { FillBlip( (*blipHandle), srblips); - //for(int i=0; isize()); i++) - // { - // auto LarBlips = (*(blipHandle))[i]; - // FillBlip( (LarBlips) , srblips); - // } } // collect the TPC slices std::vector> slices; From 19f6c9222a0b6ad13f95a59a4076b6cd49bc5ea9 Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Mon, 15 Dec 2025 16:13:39 -0600 Subject: [PATCH 15/19] Aligning fcl param code indentation --- sbncode/CAFMaker/CAFMakerParams.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sbncode/CAFMaker/CAFMakerParams.h b/sbncode/CAFMaker/CAFMakerParams.h index 5ff287d91..6843b4ad9 100644 --- a/sbncode/CAFMaker/CAFMakerParams.h +++ b/sbncode/CAFMaker/CAFMakerParams.h @@ -634,11 +634,12 @@ namespace caf Comment("Label of CVN scores."), "cvn" }; - Atom fBlipTag { Name("BlipTag"), - Comment("Provide a string to label the blip input"), "blipreco" - }; - + Atom fBlipTag { + Name("BlipTag"), + Comment("Provide a string to label the blip input"), + "blipreco" + }; }; } From bd6ecab80cc2333db63f3a137cc857c22760f177 Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Mon, 15 Dec 2025 16:16:14 -0600 Subject: [PATCH 16/19] Changed for loop per suggestion --- sbncode/CAFMaker/FillBlip.cxx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sbncode/CAFMaker/FillBlip.cxx b/sbncode/CAFMaker/FillBlip.cxx index 30194b19b..e8ea0e064 100644 --- a/sbncode/CAFMaker/FillBlip.cxx +++ b/sbncode/CAFMaker/FillBlip.cxx @@ -4,10 +4,8 @@ namespace caf { void FillBlip( const std::vector& LarBlips, std::vector& CAF_Blips) { - int NBlips = LarBlips.size(); - for(int iBlip=0; iBlip Date: Mon, 15 Dec 2025 16:53:35 -0600 Subject: [PATCH 17/19] Assorted updated per PR comments --- sbncode/CAFMaker/CAFMaker_module.cc | 2 +- sbncode/CAFMaker/FillBlip.cxx | 111 ++++++++++++++-------------- sbncode/CAFMaker/FillBlip.h | 13 +++- 3 files changed, 65 insertions(+), 61 deletions(-) diff --git a/sbncode/CAFMaker/CAFMaker_module.cc b/sbncode/CAFMaker/CAFMaker_module.cc index 86efb71b8..46c1d475c 100644 --- a/sbncode/CAFMaker/CAFMaker_module.cc +++ b/sbncode/CAFMaker/CAFMaker_module.cc @@ -1934,7 +1934,7 @@ void CAFMaker::produce(art::Event& evt) noexcept { std::vector srblips; if(evt.getByLabel( fParams.fBlipTag(), blipHandle)) //fill SR blips { - FillBlip( (*blipHandle), srblips); + FillBlip( *blipHandle, srblips); } // collect the TPC slices std::vector> slices; diff --git a/sbncode/CAFMaker/FillBlip.cxx b/sbncode/CAFMaker/FillBlip.cxx index e8ea0e064..f91d07a2b 100644 --- a/sbncode/CAFMaker/FillBlip.cxx +++ b/sbncode/CAFMaker/FillBlip.cxx @@ -2,9 +2,9 @@ namespace caf { - void FillBlip( const std::vector& LarBlips, std::vector& CAF_Blips) + void FillBlip( const std::vector& LAr_Blips, std::vector& CAF_Blips) { - for(blip::Blip const& CurrentBlip: LarBlips) + for(blip::Blip const& CurrentBlip: LAr_Blips) { caf::SRBlip NewBlip; NewBlip.ID = CurrentBlip.ID; @@ -28,70 +28,69 @@ namespace caf NewBlip.dYZ = CurrentBlip.dYZ; if(CurrentBlip.truth.ID >= 0 ) //MC Blip { - FillMCTruthBlip( CurrentBlip, NewBlip ); + FillMCTruthBlip( CurrentBlip.truth, NewBlip.truthBlip ); + } + for(int iPlane=0; iPlane #include "sbnanaobj/StandardRecord/SRBlip.h" #include "sbnobj/SBND/Blip/BlipDataTypes.h" @@ -9,9 +14,9 @@ namespace caf { - void FillBlip( const std::vector& LarBlips, std::vector& CAF_Blips); - void FillMCTruthBlip(blip::Blip& LarBlip, caf::SRBlip& CAF_Blip ); - void FillBlipRealtedHitCluster(blip::Blip& LarBlip, caf::SRBlip& CAF_Blip); + void FillBlip( const std::vector& LAr_Blips, std::vector& CAF_Blips); + void FillMCTruthBlip( blip::TrueBlip const & TrueLAr_Blip, caf::SRBlipTrueBlip &TrueCAF_Blip ); + void FillBlipRealtedHitCluster(blip::HitClust const & LAr_HitClust, caf::SRBlipHitClust &CAF_HitClust); } #endif From 5062c12e164335c35f50ce82d46e804ff1be9308 Mon Sep 17 00:00:00 2001 From: Jacob McLaughlin Date: Mon, 15 Dec 2025 17:03:10 -0600 Subject: [PATCH 18/19] Compiler issue --- sbncode/CAFMaker/FillBlip.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbncode/CAFMaker/FillBlip.cxx b/sbncode/CAFMaker/FillBlip.cxx index f91d07a2b..dce5d7cae 100644 --- a/sbncode/CAFMaker/FillBlip.cxx +++ b/sbncode/CAFMaker/FillBlip.cxx @@ -30,7 +30,7 @@ namespace caf { FillMCTruthBlip( CurrentBlip.truth, NewBlip.truthBlip ); } - for(int iPlane=0; iPlane Date: Mon, 15 Dec 2025 17:07:46 -0600 Subject: [PATCH 19/19] Compiler issue --- sbncode/CAFMaker/FillBlip.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbncode/CAFMaker/FillBlip.cxx b/sbncode/CAFMaker/FillBlip.cxx index dce5d7cae..b6c86422b 100644 --- a/sbncode/CAFMaker/FillBlip.cxx +++ b/sbncode/CAFMaker/FillBlip.cxx @@ -30,7 +30,7 @@ namespace caf { FillMCTruthBlip( CurrentBlip.truth, NewBlip.truthBlip ); } - for(int iPlane=0; iPlane