Launch

[willrax]

As @dennismajor1 mentioned (#2) this is almost ready to go. Just nee to touch up the readme and we are off. :)

[dennismajor1]

I'd also like to finish the unit tests for the remaining controllers that don't have any yet - 3 or 4 in number I think.

[dennismajor1]

Sorry forgot to answer your README question - I think something similar to the UICatalogConversion README would do.

[dennismajor1]

Is it OK to delete the canonical repo's gravity-view branch now that gravity-view VC is in the master repo Will?

[willrax]

Yep Done.

[dennismajor1]

In addition to the README update was wondering if we should make this catalog a little more Ruby like by removing the subclassing of DecorationView and instead injecting it from the examples_table_controller.

Also the base_view_controller is not really an 'is' class but rather more a 'has' class - that is subclassing should be like the the example where super is an animal and the sub is a cat whereas in this case the base class is just adding features vs expressing a specific 'animal'. So injecting the base class is more along the composition pattern of adding features to the various VC's. - at least I think that's the state we have at the moment and I.m suggesting where we should evolve it to.

Just some thoughts about why we may not want to use subclassing here.

[willrax]

I think we could even make that decoration view a module if we wanted. You're right in that it doesn't really need to be subclassed. I think going through and doing a general cleanup would be a great idea. Are you going to be at inspect?

[dennismajor1]

No - unfortunately I can't make it to inspect.

I kind of prefer injection for the DecoratorView - as you only have to do the init in the examples_ table and then send the ivar with each VC call in examples_table. The BaseView on the other hand works better as a module and in fact I think there is additional common code that could be pulled back into it IMO.

Another area for possible cleanup is to use ivars where attrs are being used at the moment - there is no real need for the attrs as far as I can tell since there is no need for an API in a catalog of example code - there may be a few attrs that are needed but would have to parse the code to figure that out.

There's likely other places where the code could be Rubified ... :-)

[willrax]

Ok. I'll have to have a re read of the code. I'm off to the states for inspect so will be in and out of contact I'll pop my thought back here when i get a chance. :)

[dennismajor1]

Sounds good Will - no rush - enjoy yourself at inspect!

On 16 May 2014 21:26, Will Raxworthy notifications@github.com wrote:

Ok. I'll have to have a re read of the code. I'm off to the states for
inspect so will be in and out of contact I'll pop my thought back here when
i get a chance. :)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/26#issuecomment-43393933
.