Interested in outside contributions towards a packaged v2.0.0 release? #3
Description
Hello!
I've forked this repository since I needed a packaged version of the RothC model for use in another project. The fork currently lives here: https://github.com/SatTerC/RothC_Py
It was originally my intention to make the minimal number of changes needed to make the model installable via pip. However, I've ended up making some quite significant changes to the code structure, although I've been reasonably careful to make sure nothing substantive has changed - the tests in that repository check that the results agree with this version on the example data you provided.
My question is: would you be interested in reviewing a very large pull request from https://github.com/SatTerC/RothC_Py, or would you prefer to leave it be / develop in your own way? For my part, I would be happy to make a few changes based on feedback, but wouldn't want to commit to reverting significant proportions of the changes I've made.
It's no problem at all if we decide not to merge the two versions. I just wanted to make the offer!
Another possible option, which could be a nice learning opportunity for e.g. a student, would be to separately tidy and package this version up, using my version as a reference as needed.
Cheers,
Joe (UK Centre for Ecology & Hydrology)