-
Notifications
You must be signed in to change notification settings - Fork 7
Open
Description
Line 51 in 2119587
| plotAlignedAnalytes(AlignObjOutput) |
IINM this is leaving a file around on the user's system e.g. during R CMD check (AlignedAnalytes.pdf).
It would be better for the examples to clean up after themselves. I get that example(plotAlignedAnalytes) is probably supposed to leave it there for the user to inspect, so I'm not sure the right way to go about this. Two suggestions:
- Put the plotting code behind
\dontrun{}and make the user run it manually; leave a comment in the example explaining why so the user knows about this side-effect. - Write a "fake" Rd file whos
\examples{}only consist of\dontshow{ try(unlink("AlignedAnalytes.pdf")) }that removes the file, put only underR CMD checkwhere all examples are run. - Change the code so that instead of plotting to PDF by default, it plots to the default device (e.g. the plot window in
interactive()sessions)
Similar for .tsv file outputs from
DIAlignR/man/alignTargetedRuns2.Rd
Line 46 in 2119587
| alignTargetedRuns2(dataPath = ".", params = params, outFile = "te1.tsv", ids = ids, applyFun = BiocParallel::bplapply) |
DIAlignR/man/progAlignRuns2.Rd
Line 53 in 2119587
| progAlignRuns2(dataPath = ".", params = params, outFile = "prog.tsv", ropenms = ropenms, ids = ids, applyFun = BiocParallel::bplapply) |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels