Skip to content

Review #1

@hairav

Description

@hairav

Hey! Rishika, congrats on submitting your first assignment for ML Summer School. I checked your assignment and here are a couple things you could have done better:

-> Assignment 1_1 Task 4 and 5: You seem to have taken the help of loops in obtaining the desired result. While that works fine, we expected the students to use built-in numpy library functions for the same. Heres why you should use built-in functions:
1. Just a single line to do most complicated tasks.
2. Makes your code more readable and easy to debug.
3. Faster as compared to loops(Google "WHY?").

-> Assignment 1_2 Comparing two line plots: You seem to have created two different graphs in the plot where you really had to draw the two curves on a single graph using twinx.

The rest of the tasks were done very well with no mistakes. Hope the review helps.
We hope the assignment was a great learning experience for you.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions