Represent Pool Proxy as ERC4626

[gabririgo]

Summary

Pool Proxy inherits ERC4626 public methods and implements them according to Rigoblock specs.

Motivation

ERC2646 provides a standard for vaults that hold tokens. While it is designed for interest-bearing vaults using one token, we could amend the Rigoblock Pool Proxy API to allow easier tracking by blockchain scanners, and possibly stats platforms. Not a top priority as its impact is limited. An interesting advantage is that we could use pre-audited code, therefore reducing the attack surface at the core protocol level.

Specification

TBD.

Rationale

To facilitate exposing smart pools' data on stats platforms, frontends, and blockchain scanners according to broadly accepted standards. To make use of more pre-audited code. the ERC-4626 standard also exposes some methods to withdraw and deposit a specific token in addition to burning and minting with the base token, which would make this RBIP a good complement to RBIP-36.

Notes

ERC-4626 standard
A sample implementation
Openzeppelin's ERC-4626

On ERC-4626 inflation attacks

A project using ERC-4626: website github

[gabririgo]

Currently it does not add value. Instead, it adds the following undesired effects:

• gas overhead when converting tokens to base token
• imprecise math on conversions for small amounts
• first mint amount inflation (not present in our implementation)
• front-running attacks, no possibility of slippage protection (which we have instead)

Those same downsides are inherited by the ERC7540 standard as well, making them not particularly desirable, unless it became easier for frontends to display data (historical stats in particular) by adopting either standard.