Merge pull request #62 from Resellio/fix/nullable-last-name

[BUG] Nullable user LastName

Author: kTrzcinskii

TickAPI/TickAPI.Tests/Customers/Services/CustomerServiceTests.cs

@@ -71,6 +71,34 @@ public async Task CreateNewCustomerAsync_WhenCustomerWithUniqueEmail_ShouldRetur
         Assert.Equal(createdAt, result.Value!.CreationDate);
         Assert.Equal(id, result.Value!.Id);
     }
+    
+    [Fact]
+    public async Task CreateNewCustomerAsync_WhenLastNameIsNull_ShouldReturnNewCustomer()
+    {
+        const string email = "new@customer.com";
+        const string firstName = "First";
+        const string lastName = null;
+        Guid id = Guid.NewGuid();
+        DateTime createdAt = new DateTime(1970, 1, 1, 8, 0, 0, DateTimeKind.Utc);
+        var dateTimeServiceMock = new Mock<IDateTimeService>();
+        dateTimeServiceMock.Setup(m => m.GetCurrentDateTime()).Returns(createdAt);
+        var customerRepositoryMock = new Mock<ICustomerRepository>();
+        customerRepositoryMock.Setup(m => m.GetCustomerByEmailAsync(email)).ReturnsAsync(Result<Customer>.Failure(StatusCodes.Status404NotFound, $"customer with email '{email}' not found"));
+        customerRepositoryMock
+            .Setup(m => m.AddNewCustomerAsync(It.IsAny<Customer>()))
+            .Callback<Customer>(c => c.Id = id)
+            .Returns(Task.CompletedTask);
+        var sut = new CustomerService(customerRepositoryMock.Object, dateTimeServiceMock.Object);
+
+        var result = await sut.CreateNewCustomerAsync(email, firstName, lastName);
+        
+        Assert.True(result.IsSuccess);
+        Assert.Equal(email, result.Value!.Email);
+        Assert.Equal(firstName, result.Value!.FirstName);
+        Assert.Equal(lastName, result.Value!.LastName);
+        Assert.Equal(createdAt, result.Value!.CreationDate);
+        Assert.Equal(id, result.Value!.Id);
+    }
 
     [Fact]
     public async Task CreateNewCustomerAsync_WhenCustomerWithNotUniqueEmail_ShouldReturnFailure()

TickAPI/TickAPI.Tests/Organizers/Services/OrganizerServiceTests.cs

@@ -112,6 +112,50 @@ public async Task CreateNewOrganizerAsync_WhenOrganizerDataIsValid_ShouldReturnN
         Assert.False(result.Value!.IsVerified);
         Assert.Equal(currentDate, result.Value!.CreationDate);
     }
+    
+    [Fact]
+    public async Task CreateNewOrganizerAsync_WhenLastNameIsNull_ShouldReturnNewOrganizer()
+    {
+        // Arrange
+        Guid id = Guid.NewGuid();
+        const string email = "example@test.com";
+        const string firstName = "First";
+        const string lastName = null;
+        const string displayName = "Display";
+        DateTime currentDate = new DateTime(1970, 1, 1, 8, 0, 0, DateTimeKind.Utc);
+
+        var organizerRepositoryMock = new Mock<IOrganizerRepository>();
+        organizerRepositoryMock
+            .Setup(m => m.GetOrganizerByEmailAsync(email))
+            .ReturnsAsync(Result<Organizer>.Failure(StatusCodes.Status404NotFound, $"organizer with email '{email}' not found"));
+        organizerRepositoryMock
+            .Setup(m => m.AddNewOrganizerAsync(It.IsAny<Organizer>()))
+            .Callback<Organizer>(o => o.Id = id)
+            .Returns(Task.CompletedTask);
+        
+        var dateTimeServiceMock = new Mock<IDateTimeService>();
+        dateTimeServiceMock
+            .Setup(m => m.GetCurrentDateTime())
+            .Returns(currentDate);
+        
+        var sut = new OrganizerService(
+            organizerRepositoryMock.Object,
+            dateTimeServiceMock.Object
+        );
+
+        // Act
+        var result = await sut.CreateNewOrganizerAsync(email, firstName, lastName, displayName);
+
+        // Assert
+        Assert.True(result.IsSuccess);
+        Assert.Equal(id, result.Value!.Id);
+        Assert.Equal(email, result.Value!.Email);
+        Assert.Equal(firstName, result.Value!.FirstName);
+        Assert.Equal(lastName, result.Value!.LastName);
+        Assert.Equal(displayName, result.Value!.DisplayName);
+        Assert.False(result.Value!.IsVerified);
+        Assert.Equal(currentDate, result.Value!.CreationDate);
+    }
 
     [Fact]
     public async Task CreateNewOrganizerAsync_WhenWithNotUniqueEmail_ShouldReturnFailure()

TickAPI/TickAPI/Customers/Models/Customer.cs

@@ -7,7 +7,7 @@ public class Customer
     public Guid Id { get; set; }
     public string Email { get; set; }
     public string FirstName { get; set; }
-    public string LastName { get; set; }
+    public string? LastName { get; set; }
     public DateTime CreationDate { get; set; }
     public ICollection<Ticket> Tickets { get; set; }    
 }