_shema in filenames

[yibeichan]

@ibevers hi, I think we should put _schema at the end of the file name,
can you change the filename in the following places?
for example, instead of using _schema_first_19, we should use _first_19_schema. You'll need to change it in the library too.

nimh-minimal/nimh_minimal/nimh_minimal_schema

Lines 62 to 70 in 26aa591

	"isAbout": "activity_path:dsm_5_parent_guardian_rated_level_1_crosscutting_s/dsm_5_parent_guardian_rated_level_1_crosscutting_s_schema_first_19",
	"variableName": "dsm_5_parent_guardian_rated_level_1_crosscutting_s_schema_first_19",
	"prefLabel": {
	"en": "DSM5 Parent first 19"
	},
	"isVis": "Number(demo_schema_interview_age) > 12*6 && Number(demo_schema_interview_age) < 12*18"
	},
	{
	"isAbout": "activity_path:dsm_5_parent_guardian_rated_level_1_crosscutting_s/dsm_5_parent_guardian_rated_level_1_crosscutting_s_schema_20_to_25",

and

nimh-minimal/nimh_minimal/nimh_minimal_schema

Lines 115 to 116 in 26aa591

	"activity_path:dsm_5_parent_guardian_rated_level_1_crosscutting_s/dsm_5_parent_guardian_rated_level_1_crosscutting_s_schema_first_19",
	"activity_path:dsm_5_parent_guardian_rated_level_1_crosscutting_s/dsm_5_parent_guardian_rated_level_1_crosscutting_s_schema_20_to_25",

@satra quick question for variableName, do we always keep _schema in the end to be consistent with the filename in isAbout or can we get rid of _schema but only have "DSM5_crosscutting_adult"? I have some vague memory that if we remove _schema from variableName we'll probably fail the validation.

nimh-minimal/nimh_minimal/nimh_minimal_schema

Lines 30 to 31 in 26aa591

	"isAbout": "activity_path:DSM-5_A/DSM5_crosscutting_adult_schema",
	"variableName": "DSM5_crosscutting_adult_schema",

[satra]

variable names can be anything. so it doesn't need to have the _schema at the end. also, i can't remember any longer why every addproperties has a variablename, especially if the response from that schema is not used anywhere.

[yibeichan]

ah, that's a good point, @djarecka you can remove _schema if it makes things easier. Also, I couldn't find how variableName was used in UI, I mean I searched it in UI but don't think I understand how it's used.

[satra]

Also, I couldn't find how variableName was used in UI, I mean I searched it in UI but don't think I understand how it's used.

you can see how the variable name for demo_schema is being used in isVis - that's all controlled by the UI (and the PR i merged to add scoped variables for calculation).

[yibeichan]

i see, it's used in isVis. i am not sure about the relationship between variableName and isAbout, like whether variableName has to be the same as the second part of isAbout (split by "/" or ":")

[satra]

isAbout expands to a url if you load it in jsonld viewer, it's not a string. it's the actual pointer to the schema for activity/item. variablename is an alphanumericstring. one points to content, the other is simply a string that gets evaluated to represent a scope or an actual value.

[yibeichan]

okay, got it, so variableName is a representation of the value in isAbout, then they don't have to be the same

[djarecka]

Ok, I understand that variableName doesn't have to be a name of the file.

But also want to point that variableName is important for the compute items. Since in compute there is no isAbout, e.g., here, variableName in addProperties is the only place where I can match variableName from compute to get path

[yibeichan]

yes, phq9_total_score is in addProperties, where isAbout exists, so as long as we keep the same variable name consistent, should it be okay to identify which is which?

[djarecka]

yes, phq9_total_score is in addProperties, where isAbout exists, so as long as we keep the same variable name consistent, should it be okay to identify which is which?

yes