diff --git a/Remora.Commands/Builders/CommandParameterBuilder.cs b/Remora.Commands/Builders/CommandParameterBuilder.cs index 601e481..c0093cf 100644 --- a/Remora.Commands/Builders/CommandParameterBuilder.cs +++ b/Remora.Commands/Builders/CommandParameterBuilder.cs @@ -60,10 +60,8 @@ public CommandParameterBuilder(CommandBuilder builder, Type type) { _name = string.Empty; _builder = builder; - _attributes = new(); - _conditions = new(); - builder.Parameters.Add(this); - + _attributes = []; + _conditions = []; _parameterType = type; } diff --git a/Tests/Remora.Commands.Tests/Builders/CommandBuilderTests.cs b/Tests/Remora.Commands.Tests/Builders/CommandBuilderTests.cs index 3495045..c724f82 100644 --- a/Tests/Remora.Commands.Tests/Builders/CommandBuilderTests.cs +++ b/Tests/Remora.Commands.Tests/Builders/CommandBuilderTests.cs @@ -65,11 +65,11 @@ public void CanBuildParameterizedCommand() var commandBuilder = new CommandBuilder() .WithName("test") .WithInvocation((_, _, _) => default) - .WithDescription("A test command."); - - _ = new CommandParameterBuilder(commandBuilder, typeof(string)) - .WithName("test") - .WithDescription("A test parameter."); + .WithDescription("A test command.") + .AddParameter(typeof(string)) + .WithName("test") + .WithDescription("A test parameter.") + .Finish(); var command = commandBuilder.Build(rootNode); @@ -90,15 +90,15 @@ public void CanBuildParameterizedCommandWithMultipleParameters() var commandBuilder = new CommandBuilder() .WithName("test") .WithInvocation((_, _, _) => default) - .WithDescription("A test command."); - - _ = new CommandParameterBuilder(commandBuilder, typeof(string)) - .WithName("test") - .WithDescription("A test parameter."); - - _ = new CommandParameterBuilder(commandBuilder, typeof(int)) - .WithName("test2") - .WithDescription("A second test parameter."); + .WithDescription("A test command.") + .AddParameter(typeof(string)) + .WithName("test") + .WithDescription("A test parameter.") + .Finish() + .AddParameter(typeof(int)) + .WithName("test2") + .WithDescription("A second test parameter.") + .Finish(); var command = commandBuilder.Build(rootNode);