remove clickable Lura runes and add a button that creates the correct 5 macros instead

Author: Reloe

EncounterAlerts/MidnightS1/MidnightFalls.lua

@@ -105,92 +105,6 @@ NSI.EncounterAlertStart[encID] = function(self, id, preview) -- on ENCOUNTER_STA
         }
         self:AddRemindersFromTable(Alert, timers[id])
     end
-    if NSRT.EncounterAlerts[encID] and NSRT.EncounterAlerts[encID].ClickableRunes and (realpull or preview) then
-        self.LuraClicks = self.LuraClicks or {}
-        self.LuraBackground = self.LuraBackground or {}
-        local numbers = {2, 3, 4, 6, 7}
-
-        local function createHighlightTexture(self)
-            local texture = self:CreateTexture(nil, "OVERLAY")
-            self.highlight = texture
-            texture:SetTexture([[Interface\QuestFrame\UI-QuestLogTitleHighlight]])
-            texture:SetBlendMode("ADD")
-            texture:SetAllPoints(self)
-            texture:SetAlpha(.4)
-            return texture
-        end
-
-        local function onButtonEnter(self)
-            if not self.highlight then
-                createHighlightTexture(self)
-            end
-            self.highlight:Show()
-            self:SetBackdropBorderColor(1, 1, 1)
-        end
-        local function onButtonLeave(self)
-            if self.highlight then
-                self.highlight:Hide()
-            end
-            self:SetBackdropBorderColor(0, 0, 0)
-        end
-        local count = 0
-        local path = {
-            [2] = [[Interface\AddOns\NorthernSkyRaidTools\Media\EncounterPics\Circle.blp]],
-            [3] = [[Interface\AddOns\NorthernSkyRaidTools\Media\EncounterPics\Diamond.blp]],
-            [4] = [[Interface\AddOns\NorthernSkyRaidTools\Media\EncounterPics\Triangle.blp]],
-            [6] = [[Interface\AddOns\NorthernSkyRaidTools\Media\EncounterPics\T.blp]],
-            [7] = [[Interface\AddOns\NorthernSkyRaidTools\Media\EncounterPics\Cross.blp]],
-        }
-        local chatmsgs = {
-            [2] = "134635", -- Circle
-            [3] = "340528", -- Diamond
-            [4] = "351033", -- Triangle
-            [6] = "7242384", -- T
-            [7] = "236903", -- Cross
-        }
-        for _, num in ipairs(numbers) do
-            count = count+1
-            if not self.LuraBackground[num] then
-                self.LuraBackground[num] = CreateFrame("Frame", nil, self.NSRTFrame, "BackdropTemplate")
-                self.LuraBackground[num]:SetBackdrop({bgFile = [[Interface\Buttons\WHITE8X8]], edgeFile = [[Interface\Buttons\WHITE8X8]], edgeSize = 1})
-                self.LuraBackground[num]:SetBackdropColor(0.5, 0.5, 0.5, 1)
-                self.LuraBackground[num]:SetBackdropBorderColor(0, 0, 0, 0.5)
-                self.LuraBackground[num].texture = self.LuraBackground[num]:CreateTexture(nil, "OVERLAY")
-                self.LuraBackground[num].texture:SetTexture(path[num])
-                self.LuraBackground[num].texture:SetAllPoints(self.LuraBackground[num])
-                self.LuraBackground[num]:SetWidth(NSRT.Settings.LuraSize or 75)
-                self.LuraBackground[num]:SetHeight(NSRT.Settings.LuraSize or 75)
-                local spacing = NSRT.Settings.LuraSize or 75
-                local offset = count*(spacing+5)
-                local xOffset = NSRT.Settings.LuraOffsetX or 200
-                local yOffset = NSRT.Settings.LuraOffsetY or -100
-                self.LuraBackground[num]:ClearAllPoints()
-                self.LuraBackground[num]:SetPoint(NSRT.Settings.LuraAnchor or "LEFT", self.NSRTFrame, NSRT.Settings.LuraRelativePoint or "LEFT", xOffset+offset, yOffset)
-            end
-            if not self.LuraClicks[num] then
-                self.LuraClicks[num] = CreateFrame("Button", "LuraRuneButton"..num, self.NSRTFrame, "SecureActionButtonTemplate,BackdropTemplate")
-                self.LuraClicks[num]:SetAllPoints(self.LuraBackground[num])
-                self.LuraClicks[num]:SetAttribute("type1", "macro")
-                self.LuraClicks[num]:SetAttribute("macrotext1", "/raid "..chatmsgs[num])
-                self.LuraClicks[num]:SetAttribute("useOnKeyDown", false)
-                self.LuraClicks[num]:RegisterForClicks("AnyUp", "AnyDown")
-                self.LuraClicks[num]:SetScript("OnEnter", onButtonEnter)
-                self.LuraClicks[num]:SetScript("OnLeave", onButtonLeave)
-            end
-            if preview then
-                self.LuraBackground[num]:SetWidth(NSRT.Settings.LuraSize or 75)
-                self.LuraBackground[num]:SetHeight(NSRT.Settings.LuraSize or 75)
-                local spacing = NSRT.Settings.LuraSize or 75
-                local offset = count*(spacing+5)
-                local xOffset = NSRT.Settings.LuraOffsetX or 200
-                local yOffset = NSRT.Settings.LuraOffsetY or -100
-                self.LuraBackground[num]:ClearAllPoints()
-                self.LuraBackground[num]:SetPoint(NSRT.Settings.LuraAnchor or "LEFT", self.NSRTFrame, NSRT.Settings.LuraRelativePoint or "LEFT", xOffset+offset, yOffset)
-            end
-            self.LuraBackground[num]:Show()
-            self.LuraClicks[num]:Show()
-        end
-    end
     if NSRT.EncounterAlerts[encID] and NSRT.EncounterAlerts[encID].RunesDisplay and (realpull or preview) then
         self.LuraRunesFrame = self.LuraRunesFrame or CreateFrame("Frame", "nil", self.NSRTFrame, "BackdropTemplate")
         self.LuraRunesFrame:ClearAllPoints()
@@ -318,17 +232,6 @@ NSI.EncounterAlertStart[encID] = function(self, id, preview) -- on ENCOUNTER_STA
 end
 
 NSI.EncounterAlertStop[encID] = function(self) -- on ENCOUNTER_END
-    if NSRT.EncounterAlerts[encID] and NSRT.EncounterAlerts[encID].ClickableRunes then
-        local numbers = {2, 3, 4, 6, 7}
-        for _, num in ipairs(numbers) do
-            if self.LuraClicks and self.LuraClicks[num] then
-                self.LuraClicks[num]:Hide()
-            end
-            if self.LuraBackground and self.LuraBackground[num] then
-                self.LuraBackground[num]:Hide()
-            end
-        end
-    end
     if self.LuraRunesFrame then
         self.LuraRunesFrame:UnregisterAllEvents()
         self.LuraRunesFrame:Hide()

UI/Options/EncounterAlerts.lua

@@ -377,75 +377,8 @@ local function BuildEncounterAlertsOptions()
         },
         {
             type = "label",
-            get = function() return "In Mythic you will want your Tank to be raidlead and click for Runes 1&4.\nHealers need to dynamically decide who is clicking, their presses will be registered for Runes 2, 3 & 5" end,
+            get = function() return "Settings changes will take into effect when you toggle the preview off & on again." end,
             text_template = DF:GetTemplate("font", "ORANGE_FONT_TEMPLATE"),
-            spacement = true,
-        },
-        {
-            type = "toggle",
-            boxfirst = true,
-            name = "Clickable Runes",
-            desc = "Enables Clickable Runes for Midnight Falls. In Mythic, your tank should be the raidleader for this to function properly.",
-            get = function() return NSRT.EncounterAlerts[3183] and NSRT.EncounterAlerts[3183].ClickableRunes end,
-            set = function(self, fixedparam, value)
-                NSRT.EncounterAlerts[3183] = NSRT.EncounterAlerts[3183] or {}
-                NSRT.EncounterAlerts[3183].ClickableRunes = value
-            end,
-            nocombat = true,
-            icontexture = 7448204,
-            iconsize = {16, 16},
-        },
-        {
-            type = "select",
-            name = "Anchor of Clickable Runes",
-            desc = "Defines the Anchor of the Clickable Runes. They will grow right from there.",
-            get = function() return NSRT.Settings.LuraAnchor or "LEFT" end,
-            values = function() return build_anchor_options("LuraAnchor") end,
-            nocombat = true,
-        },
-        {
-            type = "select",
-            name = "Relative Point of Clickable Runes",
-            desc = "Defines the Relative Point of the Clickable Runes. They will grow right from there.",
-            get = function() return NSRT.Settings.LuraRelativePoint or "LEFT" end,
-            values = function() return build_anchor_options("LuraRelativePoint") end,
-            nocombat = true,
-        },
-        {
-            type = "range",
-            name = "X-Offset of Clickable Runes",
-            desc = "X-Offset of the Clickable Runes",
-            get = function() return NSRT.Settings.LuraOffsetX or 300 end,
-            set = function(self, fixedparam, value)
-                NSRT.Settings.LuraOffsetX = value
-            end,
-            min = -2000,
-            max = 2000,
-            nocombat = true,
-        },
-        {
-            type = "range",
-            name = "Y-Offset of Clickable Runes",
-            desc = "Y-Offset of the Clickable Runes",
-            get = function() return NSRT.Settings.LuraOffsetY or 0 end,
-            set = function(self, fixedparam, value)
-                NSRT.Settings.LuraOffsetY = value
-            end,
-            min = -2000,
-            max = 2000,
-            nocombat = true,
-        },
-        {
-            type = "range",
-            name = "Width & Height of the Clickable Runes",
-            desc = "Width & Height of the Clickable Runes",
-            get = function() return NSRT.Settings.LuraSize or 100 end,
-            set = function(self, fixedparam, value)
-                NSRT.Settings.LuraSize = value
-            end,
-            min = 30,
-            max = 200,
-            nocombat = true,
         },
         {
             type = "button",
@@ -461,10 +394,26 @@ local function BuildEncounterAlertsOptions()
             end,
             nocombat = true
         },
+        {
+            type = "button",
+            name = "Create Rune-Macros",
+            desc = "This will create the macros you need for the 5 different runes, automatically using the correct icons as well. Clickable Buttons have been removed as they caused too many issues.",
+            func = function(self)
+                local iconIDs = {"134635", "340528", "351033", "7242384", "236903"}
+                for i=1, 5 do
+                    local macroName = "NSRT_LURA_RUNE_"..i
+                    if not GetMacroInfo(macroName) then
+                        CreateMacro(macroName, iconIDs[i], "/raid "..iconIDs[i])
+                    end
+                end
+            end,
+            nocombat = true
+        },
         {
             type = "label",
-            get = function() return "Settings changes will take into effect when you toggle the preview off & on again." end,
+            get = function() return "In Mythic you will want your Tank to be raidlead and click for Runes 1&4.\nHealers need to dynamically decide who is clicking, their presses will be registered for Runes 2, 3 & 5" end,
             text_template = DF:GetTemplate("font", "ORANGE_FONT_TEMPLATE"),
+            spacement = true,
         },
         {
             type = "breakline"