Only disable echo when typing password

[Trevoke]

Right now echo is disabled for everything, so I can't see anything I type.

[ConstableBrew]

What OS and client are you using?

[Blecki]

I've also been experiencing double echos since that change. The solution is in your todo comment in the echo code. There also needs to be a command to turn it off for clients that are broken.

In fact, based on experience so far, echo off should be the default option.

Sent from my HTC One on the Verizon Wireless 4G LTE network

----- Reply message -----
From: "Michael Brewer" notifications@github.com
To: "Reddit-Mud/RMUD" RMUD@noreply.github.com
Subject: [RMUD] Only disable echo when typing password (#101)
Date: Mon, Oct 20, 2014 12:01 PM

What OS and client are you using?

—
Reply to this email directly or view it on GitHub.
{"@context":"http://schema.org","@type":"EmailMessage","description":"View this Issue on GitHub","action":{"@type":"ViewAction","url":"https://github.com/Reddit-Mud/RMUD/issues/101#issuecomment-59785538","name":"View Issue"}}

[ConstableBrew]

My implementation was pretty simple and heavy handed - instead of doing proper negotiation with the client about what features to turn on/off, the demands/requests are sent and expected to be accepted. (E.g. WILL ECHO; DON't ECHO) To keep it as simple as possible, the server tells the client that it will be echoing back whatever the client types in and that the client should never do its own echo. Then on the server side, adjusting the echo settings just determines what actually gets echoed back, but the mode never changes. My assumption was that WILL ECHO; DON'T ECHO was a well supported baseline.

The fix for this is to add a proper client/server negotiation handler.

[Trevoke]

I ran into issues on OSX with raw telnet as well as tintin++.

On Mon, Oct 20, 2014 at 1:02 PM, Michael Brewer notifications@github.com
wrote:

My implementation was pretty simple and heavy handed - instead of doing
proper negotiation with the client about what features to turn on/off, the
demands/requests are sent and expected to be accepted. (E.g. WILL ECHO;
DON't ECHO) To keep it as simple as possible, the server tells the client
that it will be echoing back whatever the client types in and that the
client should never do its own echo. Then on the server side, adjusting the
echo settings just determines what actually gets echoed back, but the mode
never changes. My assumption was that WILL ECHO; DON'T ECHO was a well
supported baseline.

The fix for this is to add a proper client/server negotiation handler.

—
Reply to this email directly or view it on GitHub
#101 (comment).

[Blecki]

Okay, I've temporarily removed all of the echoing, and the telnet options meant to turn it off for the client.

I understand that the intention was to hide the password when logging in. I think we need to reconsider the approach because

1. It doesn't seem to work for many mud clients.
2. Many mud clients send entire commands at once, rather than sending input one character at a time. It can't hide the password for them anyway.

[ConstableBrew]

The negotiation will handle all that. I'll implement that soon.