Merge pull request #13 from RedMapleTech/feature/7-non-validation-errors-are-swallowed

Add detail for non-validation errors

Author: richjyoung

bind/bind.go

@@ -34,7 +34,7 @@ type bindOpts struct {
 	key      string // Context key
 	abort    bool   // Abort request on a bind error and set ctx.Error
 	response bool   // Abort request and send response immediately
-	detail   bool   // Send validation error detail as JSON in response
+	detail   bool   // Send error detail as JSON in response
 	code     int    // HTTP status code if sending a response
 }
 
@@ -108,8 +108,14 @@ func bindHandler(ctx *gin.Context, target interface{}, opts *bindOpts) {
 					"errors": errs,
 				}
 				ctx.AbortWithStatusJSON(opts.code, res)
+			} else if opts.detail {
+				// Not a validation error but detail still requested
+				ctx.AbortWithStatusJSON(opts.code, gin.H{
+					"code":  "binding_error",
+					"error": err.Error(),
+				})
 			} else {
-				// Error other than validation error
+				// Error other than validation error or detail response disabled
 				ctx.AbortWithStatus(opts.code)
 			}
 			return

bind/bind_test.go

@@ -6,6 +6,7 @@ import (
 	"io"
 	"net/http"
 	"net/http/httptest"
+	"strings"
 	"testing"
 
 	"github.com/gin-gonic/gin"
@@ -193,6 +194,24 @@ func TestBindResponseDetail(t *testing.T) {
 	assert.Equal(t, `{"code":"validation_error","errors":[{"field":"ID","rule":"uuid4"}]}`, w.Body.String())
 }
 
+func TestBindResponseDetailNotValidation(t *testing.T) {
+	type validatedBody struct {
+		ID string `json:"id" binding:"required,uuid4"`
+	}
+
+	w := httptest.NewRecorder()
+	e := gin.New()
+
+	e.POST("", To(validatedBody{}, WithDetail(true)))
+
+	req, _ := http.NewRequest("POST", "/", strings.NewReader(`{"id": "invalid_json`))
+	req.Header.Set("Content-Type", "application/json")
+
+	e.ServeHTTP(w, req)
+	assert.Equal(t, 400, w.Result().StatusCode)
+	assert.Equal(t, `{"code":"binding_error","error":"unexpected EOF"}`, w.Body.String())
+}
+
 func body(i interface{}) io.Reader {
 	buf, _ := json.Marshal(i)
 	return bytes.NewReader(buf)