Crash on loading spawns while zoning

[Redbot]

In GitLab by @Knightly1 on Nov 3, 2023, 23:04

MQ2SpawnMaster highlights named spawns on the map when zoning. This calls GetBodyType when doing the spawn search and occasionally causes a crash. See e99fa737-437c-4fa9-bd25-7cad399c7583 for more info.

[Redbot]

In GitLab by @Sicprofundus on Nov 6, 2023, 06:34

Looking at this in spawnmaster it appears to be coming from when it calls WalkSpawnList in OnEndZone().

My inclination is to add a timer to not do things until a few seconds after we zone, but that is more of treating the symptoms and not treating the problem.

I don't know if this means that there is a problem with OnEndZone or something else.

I'm trepidatious about touching much in here because I'd be inclined to try and update some of the "old code" in here like PSPAWNINFO deprecations and typedef usage of CHAR

INT Angle = (INT)((atan2f(GetCharInfo()->pSpawn->X - pSpawn->X, GetCharInfo()->pSpawn->Y - pSpawn->Y) * 180.0f / PI + 360.0f) / 22.5f + 0.5f) % 16;

[Redbot]

In GitLab by @Sicprofundus on Nov 6, 2023, 14:04

futhermore, noticing there are similiar "GetSpawnType" crashes outside of spawnmaster.

possibly just an mq2map issue causing it

[Redbot]

In GitLab by @brainiac on Nov 6, 2023, 14:23

You can't tie the crashes to spawnmaster through the crash report because the commands are deferred through the command engine, but you can see it happening here:

https://gitlab.com/redguides/plugins/mq2spawnmaster/-/blob/master/MQ2SpawnMaster.cpp#L269-276

[Redbot]

In GitLab by @brainiac on Nov 6, 2023, 14:25

There is a brief period where its possible that the spawn data is no longer valid. Those things should be removed from the list, but if two plugins both try to do things at the same time from the same callback (i.e. update spawns and clear the spawn list) then its possible that the ordering of these actions can screw things up.

would need to investigate to know more.