quickFilter assistant does not trigger after manual tag changes (Tb 147)

[jameslevalaisan]

Hello,

After changing or assigning tags to messages, Quick Filter does not react. Messages do not appear.

Observed on two different PCs.

Notes

This was working correctly about one month ago.

Impact
Filtering by tags becomes unreliable, which significantly affects workflows relying on tags.

Please let me know if more information is needed (Thunderbird version, OS, steps to reproduce, logs).

[RealRaven2000]

After changing or assigning tags to messages, Quick Filter does not react. Messages do not appear.

do you mean that the assistant is not triggered, or do your filters not work? Check the filter log whether other filters may have ran and stopped filter execution. The last quickFIlters release was on 4th of January.

[RealRaven2000]

Also - especially if this is about the assistant not starting - which version of Thunderbird are you running?

[jameslevalaisan]

Hi,
the problem is that the assistant is not triggered.
I use the version 147.0 it works with 1.44.
OS Windows 11 25h2
QuickFilter 6.10

step to reproduce. Start assisstant, add a tag to any email. Look that nothing append.

[RealRaven2000]

thanks for the clarification + title change.

the tag listener tries to patch the front end menus - I suspect the front end has changed:

quickFilters.addTagListener = function(win) {
  const util = quickFilters.Util,
    prefs = quickFilters.Preferences;
  if (!util) {
    setTimeout(function() { quickFilters.addTagListener() } , 1000); // retry
    return false; 
  }
  util.logDebugOptional('listeners', "addTagListener()");
  // wrap the original method
  if (win.mailContextMenu && win.mailContextMenu._toggleMessageTag) {
    if (!quickFilters.ToggleMessageTag) {
      util.logDebugOptional('listeners','Wrapping ToggleMessageTag...');
      let originalTagToggler = win.mailContextMenu._toggleMessageTag;
    ...

I am not doing this in a folder listener as this can be triggered by a filter action itself which would lead to triggering the assistant when its not desired. Unfortunately, just like with moving mail, the origin of the action cannot be determined - we must monitor the UI frontend for this action directly.

[RealRaven2000]

The menu exists, but there is an internal method _toggleMessageTag that doesn't. It was removed in

comm-esr128
mailCommon.js:141

    cmd_toggleTag(event) {
      mailContextMenu._toggleMessageTag(
        event.target.value,
        event.target.getAttribute("checked") == "true"
      );
    },

comm-central:
mailCommon.js:135

    cmd_toggleTag: event => {
      commandController._toggleMessageTag(
        event.target.value,
        event.target.hasAttribute("checked")
      );
    },

the change was done in https://bugzilla.mozilla.org/show_bug.cgi?id=1990790
affecting Thunderbird 145 and later.

so we need to branch out the code here a little.

[RealRaven2000]

Patched version below:

quickFilters-6.11pre42.zip

---

To install version above download zip file and drag the file into Thunderbird Add-ons Manager (do not extract contents, it won't install like that). please leave issue open - I close it when I release the changes to the public.