_VAOC_CALIBRATE_Z_OFFSET

[JCHJones]

What happened

Auto Z calibration does not work when set to true. Some of the startup procedures work but the calibration itself never happens.

What did you expect to happen

N/A

How to reproduce

N/A

Additional information

This happens because the macro _VAOC_CALIBRATE_Z_OFFSET has a bug on line 473 in macros/idex/vaoc.cfg

{% if printer["z_offset_probe"] is defined and is_started %}
should be
{% if printer["z_offset_probe"] is defined or is_started %}

(or instead of and)

As _VAOC_CALIBRATE_Z_OFFSET AUTO_Z_OFFSET=True is the call that starts the calibration but it fails to run past this line since VAOC is not started.

However the intended use of the auto_calibrate has the _VAOC_CALIBRATE_Z_OFFSET macro start the VAOC itself when auto is set to true.
It just never reaches this point.

EDIT:

Note the
_VAOC_ENSURE_TOOLHEAD_WITHIN_CONTROL_POINT
_VAOC_ENSURE_CONTROL_POINT_WITHIN_EXPECTED_CAMERA_POS

will also then cause errors when reached.

So actually instead of changing it to or leave as and and have the _START_VAOC command that is currently on line 490 be moved above line 473
I also had to remove the AUTO_Z_OFFSET=True from _START_VAOC. Because the control point safety logic does not include catches for starting in a position other than above the camera.

Though I don't think this will end up working cause of Jinja. Seems having the _START_VAOC call may need to be external to calibrate.
Only time I can get it to work.