From 555e4c41994cdaf46dfeec1f594b9c9bc1e32b44 Mon Sep 17 00:00:00 2001 From: AlexisMardas Date: Sat, 1 Jun 2024 21:40:05 +0300 Subject: [PATCH] Replace new Arraylist<>() with Collections.emptyList() where necessary --- .../java/com/squareup/javapoet/ArrayTypeName.java | 4 ++-- .../com/squareup/javapoet/ParameterizedTypeName.java | 12 ++++++------ src/main/java/com/squareup/javapoet/TypeName.java | 3 ++- .../java/com/squareup/javapoet/TypeVariableName.java | 2 +- .../java/com/squareup/javapoet/WildcardTypeName.java | 3 +-- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/main/java/com/squareup/javapoet/ArrayTypeName.java b/src/main/java/com/squareup/javapoet/ArrayTypeName.java index 7c9793f..5a37dfe 100644 --- a/src/main/java/com/squareup/javapoet/ArrayTypeName.java +++ b/src/main/java/com/squareup/javapoet/ArrayTypeName.java @@ -21,7 +21,7 @@ import java.io.IOException; import java.lang.reflect.GenericArrayType; import java.lang.reflect.Type; -import java.util.ArrayList; +import java.util.Collections; import java.util.LinkedHashMap; import java.util.List; import java.util.Map; @@ -32,7 +32,7 @@ public final class ArrayTypeName extends TypeName { public final TypeName componentType; private ArrayTypeName(TypeName componentType) { - this(componentType, new ArrayList<>()); + this(componentType, Collections.emptyList()); } private ArrayTypeName(TypeName componentType, List annotations) { diff --git a/src/main/java/com/squareup/javapoet/ParameterizedTypeName.java b/src/main/java/com/squareup/javapoet/ParameterizedTypeName.java index 3a8bf62..c70dfe9 100644 --- a/src/main/java/com/squareup/javapoet/ParameterizedTypeName.java +++ b/src/main/java/com/squareup/javapoet/ParameterizedTypeName.java @@ -19,8 +19,8 @@ import java.lang.reflect.Modifier; import java.lang.reflect.ParameterizedType; import java.lang.reflect.Type; -import java.util.ArrayList; import java.util.Arrays; +import java.util.Collections; import java.util.LinkedHashMap; import java.util.List; import java.util.Map; @@ -35,7 +35,7 @@ public final class ParameterizedTypeName extends TypeName { ParameterizedTypeName(ParameterizedTypeName enclosingType, ClassName rawType, List typeArguments) { - this(enclosingType, rawType, typeArguments, new ArrayList<>()); + this(enclosingType, rawType, typeArguments, Collections.emptyList()); } private ParameterizedTypeName(ParameterizedTypeName enclosingType, ClassName rawType, @@ -61,7 +61,7 @@ private ParameterizedTypeName(ParameterizedTypeName enclosingType, ClassName raw @Override public TypeName withoutAnnotations() { return new ParameterizedTypeName( - enclosingType, rawType.withoutAnnotations(), typeArguments, new ArrayList<>()); + enclosingType, rawType.withoutAnnotations(), typeArguments, Collections.emptyList()); } @Override CodeWriter emit(CodeWriter out) throws IOException { @@ -95,8 +95,8 @@ public TypeName withoutAnnotations() { */ public ParameterizedTypeName nestedClass(String name) { checkNotNull(name, "name == null"); - return new ParameterizedTypeName(this, rawType.nestedClass(name), new ArrayList<>(), - new ArrayList<>()); + return new ParameterizedTypeName(this, rawType.nestedClass(name), Collections.emptyList(), + Collections.emptyList()); } /** @@ -106,7 +106,7 @@ public ParameterizedTypeName nestedClass(String name) { public ParameterizedTypeName nestedClass(String name, List typeArguments) { checkNotNull(name, "name == null"); return new ParameterizedTypeName(this, rawType.nestedClass(name), typeArguments, - new ArrayList<>()); + Collections.emptyList()); } /** Returns a parameterized type, applying {@code typeArguments} to {@code rawType}. */ diff --git a/src/main/java/com/squareup/javapoet/TypeName.java b/src/main/java/com/squareup/javapoet/TypeName.java index abffddb..f2a0654 100644 --- a/src/main/java/com/squareup/javapoet/TypeName.java +++ b/src/main/java/com/squareup/javapoet/TypeName.java @@ -35,6 +35,7 @@ import java.lang.reflect.WildcardType; import java.util.ArrayList; import java.util.Arrays; +import java.util.Collections; import java.util.LinkedHashMap; import java.util.List; import java.util.Map; @@ -96,7 +97,7 @@ public class TypeName { private String cachedString; private TypeName(String keyword) { - this(keyword, new ArrayList<>()); + this(keyword, Collections.emptyList()); } private TypeName(String keyword, List annotations) { diff --git a/src/main/java/com/squareup/javapoet/TypeVariableName.java b/src/main/java/com/squareup/javapoet/TypeVariableName.java index 25385dc..47c3dc3 100644 --- a/src/main/java/com/squareup/javapoet/TypeVariableName.java +++ b/src/main/java/com/squareup/javapoet/TypeVariableName.java @@ -36,7 +36,7 @@ public final class TypeVariableName extends TypeName { public final List bounds; private TypeVariableName(String name, List bounds) { - this(name, bounds, new ArrayList<>()); + this(name, bounds, Collections.emptyList()); } private TypeVariableName(String name, List bounds, List annotations) { diff --git a/src/main/java/com/squareup/javapoet/WildcardTypeName.java b/src/main/java/com/squareup/javapoet/WildcardTypeName.java index ff4b16b..374c716 100644 --- a/src/main/java/com/squareup/javapoet/WildcardTypeName.java +++ b/src/main/java/com/squareup/javapoet/WildcardTypeName.java @@ -21,7 +21,6 @@ import java.io.IOException; import java.lang.reflect.Type; import java.lang.reflect.WildcardType; -import java.util.ArrayList; import java.util.Collections; import java.util.LinkedHashMap; import java.util.List; @@ -34,7 +33,7 @@ public final class WildcardTypeName extends TypeName { public final List lowerBounds; private WildcardTypeName(List upperBounds, List lowerBounds) { - this(upperBounds, lowerBounds, new ArrayList<>()); + this(upperBounds, lowerBounds, Collections.emptyList()); } private WildcardTypeName(List upperBounds, List lowerBounds,