FishOfThieves mod trees are not breaking when FallingTree mod installed

[lospejos]

Describe the bug

I'm not sure is it a FishOfThieves mod issue or FallingTree mod issue.

Mod trees are not breaking when FallingTree mod installed. Other mods trees and default trees breaks as expected.

Minecraft version 1.21.10 with Fabric Loader 0.17.3.

Mods installed:

Mods:
  [✔] appleskin-fabric-mc1.21.9-3.0.7
  [✔] cloth-config-20.0.149-fabric
  [✔] fabric-api-0.136.0+1.21.10
  [✔] FallingTree-1.21.10-1.21.10.1
  [✔] ferritecore-8.0.0-fabric
  [✔] fish_of_thieves-mc1.21.10-v21.10.0.0-fabric
  [✔] iris-fabric-1.9.6+mc1.21.9
  [✔] Jade-1.21.9-Fabric-20.1.0
  [✔] lambdynamiclights-4.8.5+1.21.10
  [✔] lithium-fabric-0.20.0+mc1.21.10
  [✔] modmenu-16.0.0-rc.1
  [✔] placeholder-api-2.8.1+1.21.10
  [✔] screenshotcopy-fabric-1.3.0
  [✔] sodium-extra-fabric-0.7.0+mc1.21.9
  [✔] sodium-fabric-0.7.2+mc1.21.10
  [✔] Xaeros_Minimap_25.2.15_Fabric_1.21.9
  [✔] XaerosWorldMap_1.39.17_Fabric_1.21.9

Please fix. Thanks!

See screenshot:

Isolated reproduction

Yes

Minecraft version

1.21.10

Loader used

Fabric

Loader version (Fabric/Forge/NeoForge)

0.17.3

Mod version

1.21.10-1.21.10.1

Minecraft environment

Single player

Configuration

{
  "trees": {
    "allowedLogs": [],
    "deniedLogs": [],
    "allowedLeaves": [],
    "allowedNonDecayLeaves": [],
    "deniedLeaves": [],
    "breakMode": "INSTANTANEOUS",
    "detectionMode": "WHOLE_TREE",
    "detectionModeBiomeOverride": {},
    "maxScanSize": 500,
    "minSize": 0,
    "maxSize": 100,
    "maxLeafDistanceFromLog": 15,
    "maxSizeAction": "ABORT",
    "breakOrder": "FURTHEST_FIRST",
    "minimumLeavesAroundRequired": 1,
    "includePersistentLeavesInRequiredCount": true,
    "treeBreaking": true,
    "leavesBreaking": true,
    "leavesBreakingForceRadius": 0,
    "allowMixedLogs": false,
    "breakNetherTreeWarts": true,
    "breakMangroveRoots": true,
    "searchAreaRadius": -1,
    "allowedAdjacentBlocks": [],
    "adjacentStopMode": "STOP_ALL",
    "spawnItemsAtBreakPoint": false,
    "trunkLootPercentage": 1.0
  },
  "tools": {
    "allowed": [],
    "denied": [],
    "durabilityMode": "NORMAL",
    "ignoreTools": false,
    "damageMultiplicand": 1.0,
    "damageRounding": "ROUND_DOWN",
    "speedMultiplicand": 0.0,
    "forceToolUsage": false
  },
  "player": {
    "allowedTags": []
  },
  "enchantment": {
    "requireEnchantment": false
  },
  "sneakMode": "SNEAK_DISABLE",
  "breakInCreative": false,
  "lootInCreative": true,
  "notificationMode": "ACTION_BAR"
}

Relevant log output

[lospejos]

I also created a related issue: SteveKunG/FishOfThieves#80

[Rakambda]

If tress are not detected by default, you can simply add the log and or leaf blocks into the FallingTree config.

[Rakambda]

On a more technical point of view, FallingTree consider all the default logs as being the blocks that are tagged with the "LOGS" tag.

https://github.com/RakambdaOrg/FallingTree/blob/minecraft/1.21.10/fabric/src/main/java/fr/rakambda/fallingtree/fabric/common/FallingTreeCommonsImpl.java#L181

[lospejos]

If tress are not detected by default, you can simply add the log and or leaf blocks into the FallingTree config.

Thank you for such a quick response. I would appreciate if you give some example how to properly add the log and or leaf blocks into the FallingTree config. Thanks!

[Rakambda]

https://github.com/RakambdaOrg/FallingTree/wiki/Settings---Trees
https://github.com/RakambdaOrg/FallingTree/wiki/Settings---Examples

There's examples here, though names may have changed since then I'll need to update it. Should be somthing like "alloedLogs" now.

[SteveKunG]

Hi! FoT dev here. I'm not quite sure how it does not working. My logs already included in "logs" tag. Testing by manually add my block list into the config. It seems to working only small log and block at the top does not break.

[Rakambda]

Okay, I managed to look into it, sorry for the delay.

You need to enable "Trees > Allow mixed log blocks" (or in the config file, set "allowMixedLogs": true,). As this tree is made of several blocks (depending on the width of the trunk I suppose).

[SteveKunG]

Thanks, its working now! Is there any API that I could implement into my mod?

[Rakambda]

There isn't any API for it.
At first this was put in place to limit the risk of people destroying their wooden houses in one go.

I see several solutions that can be done to avoid this kind of confusion :

• Set this setting to true by default, but it kinda defeats the purpose of security of FT. Having people turn it on manually make them aware that more "type of trees" might be taken into account.
• Have some kind of whitelist of known trees that are made of several blocks, but this isn't coded at all for now.
• What seems to be the "best" in my opinion, especially as it goes the way MC is going now, is to have it be data driven where "trees" can be defined as a set of wood blocks it is made of. That'd make it easy for other mods to integrate. It is unrelated to the mod loader. Datapacks can easily be made to "patch" a wanted custom behavior. Though this needs a bit more thinking.

For now this will stay as it, people knowing this option has to be toggled. If many more reports come I can do the whitelist as a temporary solution.