From 9afedcb438d85e7bf79e07642b7f24da796c08ab Mon Sep 17 00:00:00 2001 From: illsilin Date: Thu, 30 Mar 2023 16:21:41 -0700 Subject: [PATCH 01/16] try using label as trigger --- .github/workflows/ait_ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index 8626d301b..d46c78b3c 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -2,8 +2,8 @@ name: AITemplate_ci on: pull_request: - tags: - - rocm_ci* + label: + - rocm_ci jobs: build: From 6d6c1ece225ddb0ff20b9427f75f020697278b87 Mon Sep 17 00:00:00 2001 From: illsilin Date: Thu, 30 Mar 2023 17:03:04 -0700 Subject: [PATCH 02/16] make small change --- .github/workflows/ait_ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index d46c78b3c..f7a4f0d92 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -4,7 +4,6 @@ on: pull_request: label: - rocm_ci - jobs: build: runs-on: rocm From 04246a3b506d9b5d9a7c94027ffd5f6b013d1f4b Mon Sep 17 00:00:00 2001 From: illsilin Date: Thu, 30 Mar 2023 17:05:46 -0700 Subject: [PATCH 03/16] make another small change --- .github/workflows/ait_ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index f7a4f0d92..0e8632303 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -4,6 +4,8 @@ on: pull_request: label: - rocm_ci + + jobs: build: runs-on: rocm From 91cce1dbf85a092b83ecf9478c96cc65435a0165 Mon Sep 17 00:00:00 2001 From: illsilin Date: Thu, 30 Mar 2023 17:48:24 -0700 Subject: [PATCH 04/16] try module: rocm label --- .github/workflows/ait_ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index 0e8632303..9277933cf 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -3,8 +3,7 @@ name: AITemplate_ci on: pull_request: label: - - rocm_ci - + - 'module: rocm' jobs: build: From b29936d15e6b27691ba3bad37f6768bb6cec32bc Mon Sep 17 00:00:00 2001 From: illsilin Date: Thu, 30 Mar 2023 18:06:14 -0700 Subject: [PATCH 05/16] use an if to check the label --- .github/workflows/ait_ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index 9277933cf..dc9a3545b 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -2,11 +2,11 @@ name: AITemplate_ci on: pull_request: - label: - - 'module: rocm' + types: [labeled] jobs: build: + if: ${{ github.event.label.name == 'module: rocm' }} runs-on: rocm steps: From 97b30dad20cf4d88649d04f5ea84ded7b1285252 Mon Sep 17 00:00:00 2001 From: illsilin Date: Thu, 30 Mar 2023 18:12:00 -0700 Subject: [PATCH 06/16] use different syntax to check label --- .github/workflows/ait_ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index dc9a3545b..3d3437409 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -6,7 +6,7 @@ on: jobs: build: - if: ${{ github.event.label.name == 'module: rocm' }} + if: contains(github.event.pull_request.labels.*.name, 'module: rocm') runs-on: rocm steps: From 3ee7f2b09fd0d952035d8de4665f56afde5624f8 Mon Sep 17 00:00:00 2001 From: illsilin Date: Thu, 30 Mar 2023 18:26:58 -0700 Subject: [PATCH 07/16] only check if rocm is in label --- .github/workflows/ait_ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index 3d3437409..5f4dd6f95 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -6,7 +6,7 @@ on: jobs: build: - if: contains(github.event.pull_request.labels.*.name, 'module: rocm') + if: contains(github.event.pull_request.labels.*.name, 'rocm') runs-on: rocm steps: From 47aa08cea657e4b07164daa4088e37dc7d454f42 Mon Sep 17 00:00:00 2001 From: illsilin Date: Thu, 30 Mar 2023 18:51:51 -0700 Subject: [PATCH 08/16] use github.event.labels --- .github/workflows/ait_ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index 5f4dd6f95..84f190d1a 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -6,7 +6,7 @@ on: jobs: build: - if: contains(github.event.pull_request.labels.*.name, 'rocm') + if: contains(github.event.labels.*.name, 'rocm') runs-on: rocm steps: From b2b9acca78b65cc1a5259b21308c83f10c40c51e Mon Sep 17 00:00:00 2001 From: illsilin Date: Fri, 31 Mar 2023 11:37:16 -0700 Subject: [PATCH 09/16] try adding push trigger --- .github/workflows/ait_ci.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index 84f190d1a..bce7cc001 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -1,12 +1,16 @@ name: AITemplate_ci on: + push: + branches: + - amd-develop + - main pull_request: types: [labeled] jobs: build: - if: contains(github.event.labels.*.name, 'rocm') + if: contains(github.event.pull_request.labels.*.name, 'rocm') runs-on: rocm steps: From d63954646374ce6a2027edc69da5a2368d795fc0 Mon Sep 17 00:00:00 2001 From: illsilin Date: Fri, 31 Mar 2023 11:57:29 -0700 Subject: [PATCH 10/16] try different syntax for labeled --- .github/workflows/ait_ci.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index bce7cc001..2aaae14ca 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -3,10 +3,11 @@ name: AITemplate_ci on: push: branches: - - amd-develop - - main + - amd-develop + - main pull_request: - types: [labeled] + types: + - labeled jobs: build: From 9870204b012c1d10f9de91e7353a4d7ff850c53c Mon Sep 17 00:00:00 2001 From: illsilin Date: Fri, 31 Mar 2023 12:24:05 -0700 Subject: [PATCH 11/16] match exact label name --- .github/workflows/ait_ci.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index 2aaae14ca..5233dca58 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -1,17 +1,11 @@ name: AITemplate_ci on: - push: - branches: - - amd-develop - - main pull_request: - types: - - labeled jobs: build: - if: contains(github.event.pull_request.labels.*.name, 'rocm') + if: contains(github.event.pull_request.labels.*.name, 'module: rocm') runs-on: rocm steps: From a1172318564f4eaddbbfd503b6e346a52ee4300a Mon Sep 17 00:00:00 2001 From: illsilin Date: Fri, 31 Mar 2023 12:29:16 -0700 Subject: [PATCH 12/16] add the PR types labeled to trigger --- .github/workflows/ait_ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index 5233dca58..b90c5488e 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -2,6 +2,8 @@ name: AITemplate_ci on: pull_request: + types: + - labeled jobs: build: From 069a199c2985bfd851b2ede5c203b1086389752b Mon Sep 17 00:00:00 2001 From: illsilin Date: Fri, 31 Mar 2023 12:34:49 -0700 Subject: [PATCH 13/16] try usign github.event.label.name --- .github/workflows/ait_ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index b90c5488e..309d97c90 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -7,7 +7,8 @@ on: jobs: build: - if: contains(github.event.pull_request.labels.*.name, 'module: rocm') + #if: contains(github.event.pull_request.labels.*.name, 'module: rocm') + if: ${{ github.event.label.name == "module: rocm" }} runs-on: rocm steps: From af7b0f1094b191671cb02b47c1513b1458eb0b4d Mon Sep 17 00:00:00 2001 From: illsilin Date: Fri, 31 Mar 2023 12:42:10 -0700 Subject: [PATCH 14/16] fix syntax --- .github/workflows/ait_ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index 309d97c90..ad88ac474 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -2,8 +2,7 @@ name: AITemplate_ci on: pull_request: - types: - - labeled + types: [labeled] jobs: build: From 52c9cab33abef9035f4c38c38ff5916bf130770e Mon Sep 17 00:00:00 2001 From: illsilin Date: Fri, 31 Mar 2023 12:47:21 -0700 Subject: [PATCH 15/16] remove the conditions --- .github/workflows/ait_ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index ad88ac474..8d347dc0f 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -6,8 +6,6 @@ on: jobs: build: - #if: contains(github.event.pull_request.labels.*.name, 'module: rocm') - if: ${{ github.event.label.name == "module: rocm" }} runs-on: rocm steps: From 1aff1d7e8196781391c0e93950da025ff5e5a700 Mon Sep 17 00:00:00 2001 From: illsilin Date: Fri, 31 Mar 2023 12:53:33 -0700 Subject: [PATCH 16/16] check if label contains rocm --- .github/workflows/ait_ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ait_ci.yml b/.github/workflows/ait_ci.yml index 8d347dc0f..b73812749 100644 --- a/.github/workflows/ait_ci.yml +++ b/.github/workflows/ait_ci.yml @@ -6,6 +6,7 @@ on: jobs: build: + if: contains(github.event.label.name, 'rocm') runs-on: rocm steps: