Properly clear icon (from #92)

Author: VirxEC

frontend/src/index.ts

@@ -85,7 +85,7 @@ export function draggablePlayerToPlayerJs(d: DraggablePlayer): PlayerJs {
     }
     // We don't need to know the icon to start a bot.
     // This fixes oversized requests that result in a CORS error on windows (WebView2)
-    player.config.settings.logoFile = "";
+    player.icon = "";
 
     return {
       sort: "rlbot",

frontend/src/pages/Home.svelte

@@ -220,7 +220,7 @@ async function updateBots() {
     distinguishDuplicates(result).map(([x, uniquePathSegment]) => {
       return {
         displayName: x.config.settings.name,
-        icon: x.config.settings.logoFile,
+        icon: x.icon,
         player: new BotInfo(x),
         id: crypto.randomUUID(),
         tags: x.config.details.tags,

players.go

@@ -163,6 +163,7 @@ type BotInfo struct {
 	Config   BotConfig      `json:"config"`
 	Loadout  *LoadoutConfig `json:"loadout,omitempty"`
 	TomlPath string         `json:"tomlPath"`
+	Icon 	 string 		`json:"icon"`
 }
 
 func (botInfo BotInfo) ToPlayerConfig(team uint32) *flat.PlayerConfigurationT {
@@ -279,6 +280,7 @@ func (a *App) GetBots(paths []string) []BotInfo {
 		}
 
 		// Read logo file and convert it to data url so the frontend can use it
+		var icon string;
 		logo_data, err := os.ReadFile(logo_file)
 		if err != nil {
 			// only warn if the logo file was explicitly set
@@ -288,7 +290,7 @@ func (a *App) GetBots(paths []string) []BotInfo {
 		} else {
 			mtype := mimetype.Detect(logo_data)
 			b64data := base64.StdEncoding.EncodeToString(logo_data)
-			conf.Settings.LogoFile = "data:" + mtype.String() + ";base64," + b64data
+			icon = "data:" + mtype.String() + ";base64," + b64data
 		}
 
 		var loadout *LoadoutConfig = nil
@@ -304,6 +306,7 @@ func (a *App) GetBots(paths []string) []BotInfo {
 			Config:   conf,
 			Loadout:  loadout,
 			TomlPath: potentialConfigPath,
+			Icon: icon,
 		})
 	}