Hierarchical portgroup search works with a local repo but apparently fails with rsync source

[barracuda156]

@RJVB I have noticed that for some reason hierarchical portgroup search does not work when the overlay repo is not local file://${path} but rsync source (which is set above MacPorts upstream one). Is this something by design or I did something wrong? This will break stuff, I have to fix it at least for my fork.

[barracuda156]

Yeah, looks like nothing messed up, it is indeed the case, that local overlays are respected while rsync ones are not.

[RJVB]

On Monday January 20 2025 20:56:29 Sergey Fedorov wrote: Yeah, looks like nothing messed up, it is indeed the case, that local overlays are respected while rsync ones are not.

I'm not surprised, I don't think that my modified code is designed to handle rsync sources. I'll be happy to include a fix for that (if I understand it and all that ;) )

[barracuda156]

@RJVB Not sure if I can fix it in the code, but I will take a look. In the worst case I could perhaps do a git sync for overlay repo instead of rsync. But that would require everyone using my ports to install a bootstrap git to begin with (not a problem on a desktop, but undesirable for older PowerBooks with small HDDs).

[RJVB]

On Tuesday January 21 2025 06:32:43 Sergey Fedorov wrote: @RJVB Not sure if I can fix it in the code, but I will take a look.

It shouldn't be too hard; you'd have to extend `macports::getlocalporttreelist` in macports.tcl to handle the `rsync` protocol. I don't really want to delve into how the different (2?) supported rsync:// forms are translated into an actual local directory (though I could use the distraction...) but that shouldn't be too hard to find. There may even be a function that handles this already. You'd just have to lappend that path to `sourcetreelist`.

[barracuda156]

This seems to work: macos-powerpc/macports-base@cd174d4
Not thoroughly tested at the moment, but solved the problem with Qt4 PGs at least.

[RJVB]

On Wednesday January 22 2025 05:03:06 Sergey Fedorov wrote: This seems to work: macos-powerpc/macports-base@cd174d4

The name of the function indeed suggests that is should do what's needed - translate an rsync path or rsync tarball to a local ports tree directory.

[barracuda156]

AFAICT, works correctly.