Cannot save *.dpl files: format not supported

[smaslovski]

Hi,

I do not know if it was an intended change, but at the moment qucs cannot save *.dpl files at all. I get this error:

"Cannot save document: file format not supported."

See the attached screenshot.

BR,

Stanislav

[smaslovski]

Some more info on this bug: here is the output from console when the bug appears:

$ qucs
Info DocName "/home/stas/.qucs/test.sch"
Info schematic_file_read.cpp : readLegacy
Info DocName "/home/stas/.qucs/test.dpl"
Warning: QVariant::save: unable to save type 'iconCompInfoStruct' (type id: 1065).

Warning: QObject::connect: No such signal QTabWidget::currentChanged(QWidget*)

[felix-salfelder]

On Mon, Mar 10, 2025 at 07:21:37AM -0700, smaslovski wrote: smaslovski left a comment (Qucs/qucs#1102) Some more info on this bug: here is the output from console when the bug appears: ``` $ qucs Info DocName "/home/stas/.qucs/test.sch" Info schematic_file_read.cpp : readLegacy Info DocName "/home/stas/.qucs/test.dpl" Warning: QVariant::save: unable to save type 'iconCompInfoStruct' (type id: 1065). Warning: QObject::connect: No such signal QTabWidget::currentChanged(QWidget*) ```

Thanks for letting us know. This bug could well be related to recent work. We have recently introduced tests (but no .dpl yet) and this may be an opportunity to improve further. I assume that the output above involves manual interaction with the GUI. We need a test (possibly with patch) that triggers the bug without using the GUI. (There will be some refactoring going on for a while and I do not wish to get involved with changes to code not covered by tests.)

[smaslovski]

Hi,

The following patch seems to fix the problem:

diff --git a/qucs/schematic_file_write.cpp b/qucs/schematic_file_write.cpp
index 6abeffd8b..c4a80220f 100644
--- a/qucs/schematic_file_write.cpp
+++ b/qucs/schematic_file_write.cpp
@@ -506,7 +506,8 @@ int Schematic::saveDocument(QString OutputFileName, QString OutputTypeName)
     delete file;
     return -1;
   }
-  if(QFileInfo(OutputFileName).suffix()=="sch" || OutputTypeName=="sch") {
+  if(QFileInfo(OutputFileName).suffix()=="sch" || OutputTypeName=="sch" ||
+     QFileInfo(OutputFileName).suffix()=="dpl" || OutputTypeName=="dpl") {
       return saveSchematicDocument(file);
   }
   if(QFileInfo(OutputFileName).suffix()=="vs" || OutputTypeName=="vs") {

BR,

Stanislav