From 25cc155fbe280334e7c5cbc19d2f4b5d1a71c390 Mon Sep 17 00:00:00 2001 From: Tom Russo Date: Mon, 28 Nov 2022 12:08:00 -0700 Subject: [PATCH] Flag LRM-compliant output variables in adms data tree Per issue Qucs/ADMS#72, the implicit rules in adms.implicit.xml only flag a variable in the data tree with "output=yes" in the data tree if they have the attribute 'ask="yes"'. The LRM (Verilog-AMS LRM version 2.4, section 3.2.1) says that module-scoped variables with either "desc" or "units" attributes should be designated as output variables. This commit modifies adms.implicit.xml to set the "output" field of the data tree to "yes" if the variable is not an input variable (parameter) and is module scoped, and if it has either a "desc" or a "units" (or both) attribute. The Xyce team has been using a patched adms.implicit.xml with this modification for a couple of years, and I had simply forgotten that I'd opened issue Qucs/ADMS#72 asking that it be done in ADMS itself. Qucs/ADMS#72 --- admsXml/adms.implicit.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/admsXml/adms.implicit.xml b/admsXml/adms.implicit.xml index c2b2d7a..16c4c04 100644 --- a/admsXml/adms.implicit.xml +++ b/admsXml/adms.implicit.xml @@ -594,6 +594,15 @@ + + + + + + +