feedback copilot

Author: MariusMerkleQC

diffly/_conditions.py

@@ -206,7 +206,11 @@ def _compare_sequence_columns(
         n_elements = dtype_right.shape[0]
         has_same_length = col_left.list.len().eq(pl.lit(n_elements))
     else:  # pl.List vs pl.List
-        assert max_list_length is not None
+        if max_list_length is None:
+            raise ValueError(
+                "max_list_length must be provided for List-vs-List comparisons "
+                "in _compare_sequence_columns()."
+            )
         n_elements = max_list_length
         has_same_length = col_left.list.len().eq_missing(col_right.list.len())
 

tests/test_conditions.py

@@ -435,13 +435,31 @@ def test_condition_equal_columns_lists_only_inner() -> None:
     lhs = pl.DataFrame(
         {
             "pk": [1, 2],
-            "a_left": [{"x": 1, "y": [1.0, 2.0, 3.0]}, {"x": 2, "y": [4.0, 5.0, 6.0]}],
+            "a_left": [
+                {
+                    "x": 1,
+                    "y": [1.0, 2.0, 3.0],
+                },
+                {
+                    "x": 2,
+                    "y": [4.0, 5.0, 6.0],
+                },
+            ],
         },
     )
     rhs = pl.DataFrame(
         {
             "pk": [1, 2],
-            "a_right": [{"x": 1, "y": [1.0, 2.1, 3.0]}, {"x": 2, "y": [4.0, 5.3, 6.0]}],
+            "a_right": [
+                {
+                    "x": 1,
+                    "y": [1.0, 2.1, 3.0],
+                },
+                {
+                    "x": 2,
+                    "y": [4.0, 5.3, 6.0],
+                },
+            ],
         },
     )