Skip to content

feat(keda): enable keda for GCP and fix error when creating a service without autoscaler #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pggb25 merged 2 commits into from
Jan 29, 2026
Merged

feat(keda): enable keda for GCP and fix error when creating a service without autoscaler #2345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f31d02
feat(keda): allow keda for GCP cluster
pggb25 Jan 29, 2026
e4118cc
fix(keda): when creating a service with no autoscaler, we created a s…
pggb25 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...vices/src/lib/feature/page-application-create-feature/page-application-create-feature.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ export function PageApplicationCreateFeature() {
cpu: 500,
gpu: 0,
min_running_instances: 1,
max_running_instances: 2,
autoscaling_mode: 'HPA',
max_running_instances: 1,
autoscaling_mode: 'NONE',
hpa_metric_type: 'CPU',
hpa_cpu_average_utilization_percent: 60,
})
Expand Down
14 changes: 11 additions & 3 deletions ...application-settings/ui/application-settings-resources/application-settings-resources.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,17 +73,25 @@ export function ApplicationSettingsResources({
const hpaMemoryAverageUtilizationPercent = watch('hpa_memory_average_utilization_percent') ?? 60
const previousAutoscalingModeRef = useRef(autoscalingMode)

// Adjust min/max values when switching from NONE to HPA or KEDA
// Adjust min/max values when switching between autoscaling modes
useEffect(() => {
const previousMode = previousAutoscalingModeRef.current

// When switching from no autoscaling to HPA/KEDA, set min=1 and max=2
if (previousMode === 'NONE' && (autoscalingMode === 'HPA' || autoscalingMode === 'KEDA')) {
// When switching from no autoscaling to HPA/KEDA, set min=1 and max=2
if (minRunningInstances === maxRunningInstances) {
setValue('min_running_instances', 1)
setValue('max_running_instances', 2)
}
}

// When switching to no autoscaling (NONE), ensure max equals min
if ((previousMode === 'HPA' || previousMode === 'KEDA') && autoscalingMode === 'NONE') {
if (minRunningInstances !== maxRunningInstances) {
setValue('max_running_instances', minRunningInstances)
}
}

// Set default HPA settings when switching to HPA mode
if (autoscalingMode === 'HPA' && !hpaMetricTypeRaw) {
const hpaSettings = loadHpaSettingsFromAdvancedSettings(advancedSettings)
Expand Down Expand Up @@ -322,7 +330,7 @@ export function ApplicationSettingsResources({
{ label: 'HPA (Horizontal Pod Autoscaler)', value: 'HPA' },
]

if (cloudProvider === 'AWS' && isKedaCluster && isKedaFeatureEnabled) {
if ((cloudProvider === 'AWS' || cloudProvider === 'GCP') && isKedaCluster && isKedaFeatureEnabled) {
options.push({ label: 'KEDA (Event-driven autoscaling)', value: 'KEDA' })
}

Expand Down
2 changes: 1 addition & 1 deletion ...-shared/src/lib/cluster-settings/ui/cluster-general-settings/cluster-general-settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export function ClusterGeneralSettings(props: ClusterGeneralSettingsProps) {
)}
</>
)}
{fromDetail && cloudProvider === 'AWS' && isKedaFeatureEnabled && (
{fromDetail && (cloudProvider === 'AWS' || cloudProvider === 'GCP') && isKedaFeatureEnabled && (
<Controller
name="keda.enabled"
control={control}
Expand Down