Skip to content

There are no default parameters in BayesianOnline, unlike BayesianAlgorithm #58

@iraedeus

Description

@iraedeus

Default parameters in BayesianAlgorithm:

class BayesianAlgorithm(                                                                                                                
        learning_steps: int = 50,                                                                                                           
        likelihood: ILikelihood = GaussianConjugate(),                                                             
        hazard: IHazard = ConstantHazard(rate=1 / (1 - 0.5 ** (1 / 500))),                                         
        detector: IDetector = ThresholdDetector(threshold=0.04),                                                   
        localizer: ILocalizer = ArgmaxLocalizer()                                                                 
)    

But there are no default parameters in BayesianOnline:

 class BayesianOnline(                                                                                                                   
          hazard: IHazard,                                                                                                                    
          likelihood: ILikelihood,                                                                                                            
          learning_sample_size: int,                                                                                 
          detector: IDetector,                                                                                       
          localizer: ILocalizer                                                                                      
)  

I think we should add default parameters to BayesianAlgorithm too. And change attribute name in one of the classes to bring them to one format: learning_steps or learning_sample_size

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions