From e10a0502c11e1ea30240ac8bca1b220eb8ad1dc8 Mon Sep 17 00:00:00 2001 From: Oleh Prypin Date: Thu, 12 Mar 2026 23:46:40 +0100 Subject: [PATCH 1/2] Fix some failing tests --- properdocs/tests/build_tests.py | 6 ++++-- properdocs/tests/config/config_options_tests.py | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/properdocs/tests/build_tests.py b/properdocs/tests/build_tests.py index ed8b9868..b20899f3 100644 --- a/properdocs/tests/build_tests.py +++ b/properdocs/tests/build_tests.py @@ -586,7 +586,8 @@ def test_draft_docs_with_comments_from_user_guide(self, site_dir, docs_dir): docs_dir=docs_dir, site_dir=site_dir, use_directory_urls=False, - draft_docs=''' + draft_docs=textwrap.dedent( + ''' # A "drafts" directory anywhere. drafts/ @@ -595,7 +596,8 @@ def test_draft_docs_with_comments_from_user_guide(self, site_dir, docs_dir): # But keep this particular file. !/foo_unpublished.md - ''', + ''' + ), ) with self.subTest(serve_url=None): diff --git a/properdocs/tests/config/config_options_tests.py b/properdocs/tests/config/config_options_tests.py index b4298fdb..c97a572b 100644 --- a/properdocs/tests/config/config_options_tests.py +++ b/properdocs/tests/config/config_options_tests.py @@ -1135,7 +1135,7 @@ class Schema(Config): r"Unrecognised theme name: 'mkdocs2'. The available installed themes are: .+" ) ): - self.get_config(Schema, {'theme': "mkdocs2", 'plugins': "search"}) + self.get_config(Schema, {'theme': "mkdocs2", 'plugins': ["search"]}) def test_theme_default(self) -> None: class Schema(Config): From fc5aeb8be2b2cb1cc505ebb1989d6588dc40c347 Mon Sep 17 00:00:00 2001 From: Oleh Prypin Date: Fri, 13 Mar 2026 00:12:05 +0100 Subject: [PATCH 2/2] Fix livereload not being enabled by default with click>8.2.1 --- properdocs/__main__.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/properdocs/__main__.py b/properdocs/__main__.py index a3d9c7b3..8e700a6d 100644 --- a/properdocs/__main__.py +++ b/properdocs/__main__.py @@ -254,8 +254,8 @@ def cli(): @cli.command(name="serve") @click.option('-a', '--dev-addr', help=dev_addr_help, metavar='') @click.option('-o', '--open', 'open_in_browser', help=serve_open_help, is_flag=True) -@click.option('--no-livereload', 'livereload', flag_value=False, help=no_reload_help) -@click.option('--livereload', 'livereload', flag_value=True, default=True, hidden=True) +@click.option('--no-livereload', is_flag=True, help=no_reload_help) +@click.option('--livereload', is_flag=True, hidden=True) @click.option('--dirtyreload', 'build_type', flag_value='dirty', hidden=True) @click.option('--dirty', 'build_type', flag_value='dirty', help=serve_dirty_help) @click.option('-c', '--clean', 'build_type', flag_value='clean', help=serve_clean_help) @@ -269,6 +269,11 @@ def serve_command(**kwargs): """Run the builtin development server.""" from properdocs.commands import serve + if kwargs.pop('no_livereload', False): + kwargs['livereload'] = False + else: + kwargs['livereload'] = True + _enable_warnings() serve.serve(**kwargs)