Skip to content

Commit 7ff1aac

Browse files
authored
Merge pull request #14 from ProperDocs/livereld
Fix livereload not being enabled by default with click>8.2.1
2 parents 7c011cf + fc5aeb8 commit 7ff1aac

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

properdocs/__main__.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,8 +254,8 @@ def cli():
254254
@cli.command(name="serve")
255255
@click.option('-a', '--dev-addr', help=dev_addr_help, metavar='<IP:PORT>')
256256
@click.option('-o', '--open', 'open_in_browser', help=serve_open_help, is_flag=True)
257-
@click.option('--no-livereload', 'livereload', flag_value=False, help=no_reload_help)
258-
@click.option('--livereload', 'livereload', flag_value=True, default=True, hidden=True)
257+
@click.option('--no-livereload', is_flag=True, help=no_reload_help)
258+
@click.option('--livereload', is_flag=True, hidden=True)
259259
@click.option('--dirtyreload', 'build_type', flag_value='dirty', hidden=True)
260260
@click.option('--dirty', 'build_type', flag_value='dirty', help=serve_dirty_help)
261261
@click.option('-c', '--clean', 'build_type', flag_value='clean', help=serve_clean_help)
@@ -269,6 +269,11 @@ def serve_command(**kwargs):
269269
"""Run the builtin development server."""
270270
from properdocs.commands import serve
271271

272+
if kwargs.pop('no_livereload', False):
273+
kwargs['livereload'] = False
274+
else:
275+
kwargs['livereload'] = True
276+
272277
_enable_warnings()
273278
serve.serve(**kwargs)
274279

properdocs/tests/build_tests.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,8 @@ def test_draft_docs_with_comments_from_user_guide(self, site_dir, docs_dir):
586586
docs_dir=docs_dir,
587587
site_dir=site_dir,
588588
use_directory_urls=False,
589-
draft_docs='''
589+
draft_docs=textwrap.dedent(
590+
'''
590591
# A "drafts" directory anywhere.
591592
drafts/
592593
@@ -595,7 +596,8 @@ def test_draft_docs_with_comments_from_user_guide(self, site_dir, docs_dir):
595596
596597
# But keep this particular file.
597598
!/foo_unpublished.md
598-
''',
599+
'''
600+
),
599601
)
600602

601603
with self.subTest(serve_url=None):

properdocs/tests/config/config_options_tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1135,7 +1135,7 @@ class Schema(Config):
11351135
r"Unrecognised theme name: 'mkdocs2'. The available installed themes are: .+"
11361136
)
11371137
):
1138-
self.get_config(Schema, {'theme': "mkdocs2", 'plugins': "search"})
1138+
self.get_config(Schema, {'theme': "mkdocs2", 'plugins': ["search"]})
11391139

11401140
def test_theme_default(self) -> None:
11411141
class Schema(Config):

0 commit comments

Comments
 (0)