General Code Feedback/Issues #66
Description
Feel free to ask questions about any of these
General Issues
- Improve readability in the constants. Code is split across way too many lines & weirdly indented.
- Access should only be given where it is necessary
- Commands should have the subsystems passed in as constructor parameters, not accessed wherever.
- Commands should be in the command folder to keep things organized
- Reduces time looking for a command that is in a subsystem folder
- Complicated naming in command factories makes reading it difficult
Flippable
- Shouldn't flip sides based off time, should do it only when alliance flips sides
- Fixable by making a trigger that changes when the alliance changes
- Could theoretically cause issues with going to the wrong side