Skip to content

Enable private s3 datastores #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brucetony merged 2 commits into from
Jan 28, 2026
Merged

Enable private s3 datastores #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b551f4a
feat(s3): enable private bucket fields
brucetony Jan 28, 2026
7ebae6d
feat(s3): add minio config to data store request
brucetony Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions components/data-stores/create/DataStoreProjectInitializer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ const dataStoreSettingsMap: Map<string, string> = new Map([
["path", "Data path or bucket name"],
["port", "Port"],
["protocol", "Connection protocol"],
["accessKey", "Bucket access key"],
["secretKey", "S3 secret key"],
["minio_access_key", "MinIO access key"],
["minio_secret_key", "MinIO secret key"],
]);

// Datastore settings
Expand Down Expand Up @@ -114,17 +114,19 @@ function verifyValuesFilled(settings: object): boolean {
}

async function onSubmitCreateDataStoreAndProject() {
const validatedPath = validatePath(path.value); // Adds "/" to name if missing
const datastoreSettings = {
name: dataStoreName.value,
host: host.value,
path: validatePath(path.value),
path: validatedPath,
port: port.value,
protocol: protocol.value,
s3: {
bucketAccess: selectedBucketAccessPolicy.value || "Public",
accessKey: bucketAccessKey.value || "",
secretKey: bucketSecretKey.value || "",
},
};

const minioSettings = {
minio_access_key: bucketAccessKey.value || "",
minio_secret_key: bucketSecretKey.value || "",
// bucket_name: validatedPath, // .replace(/^\//, ""), // Removing leading "/" if present
};

// Check settings are filled in
Expand All @@ -134,8 +136,7 @@ async function onSubmitCreateDataStoreAndProject() {
selectedDataStoreType.value == "S3" &&
selectedBucketAccessPolicy.value == "Private"
) {
settingsValidated =
settingsValidated && verifyValuesFilled(datastoreSettings.s3);
settingsValidated = settingsValidated && verifyValuesFilled(minioSettings);
}

if (settingsValidated) {
Expand All @@ -147,6 +148,10 @@ async function onSubmitCreateDataStoreAndProject() {
ds_type: selectedDataStoreType.value.toLowerCase() as string,
};

if (selectedBucketAccessPolicy.value == "Private") {
configSettings["minio_config"] = minioSettings;
}

loading.value = true;
const creationResp = await useNuxtApp()
.$hubApi("/kong/initialize", {
Expand Down Expand Up @@ -297,16 +302,10 @@ async function onSubmitCreateDataStoreAndProject() {
</div>
</InputGroupAddon>
<InputGroupAddon class="data-store-field-value">
<div
class="flex flex-wrap gap-4 bucket-access-policy-radio"
v-tooltip.top="
'Selection disabled, support for Private buckets will be added soon'
"
>
<div class="flex flex-wrap gap-4 bucket-access-policy-radio">
<div class="flex items-center gap-2">
<RadioButton
v-model="selectedBucketAccessPolicy"
:disabled="true"
inputId="public"
name="accessPolicy"
value="Public"
Expand All @@ -319,7 +318,6 @@ async function onSubmitCreateDataStoreAndProject() {
<RadioButton
v-model="selectedBucketAccessPolicy"
inputId="private"
:disabled="true"
name="accessPolicy"
value="Private"
size="small"
Expand All @@ -345,7 +343,7 @@ async function onSubmitCreateDataStoreAndProject() {
<InputText
v-model="bucketAccessKey"
:invalid="bucketAccessKey === ''"
placeholder="Bucket access key"
placeholder="Access key"
/>
</InputGroup>
<InputGroup
Expand All @@ -363,7 +361,7 @@ async function onSubmitCreateDataStoreAndProject() {
<InputText
v-model="bucketSecretKey"
:invalid="bucketSecretKey === ''"
placeholder="S3 secret key"
placeholder="Secret key"
/>
</InputGroup>
</div>
Expand Down
Loading