You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 24, 2018. It is now read-only.
Love your code, but I have an issue with the menu plugin. In skrollr you check for the existence of require and load it as a modal if its there or else add it to the window instance. In the menu control, you just assume that require.js does not exist and just try to pull it from the window object:
var MENU_DURATION_ATTR = 'data-menu-duration';
var MENU_IGNORE_ATTR = 'data-menu-ignore';
var skrollr = window.skrollr; <-------- is this right?
var history = window.history;
var supportsHistory = !!history.pushState;
Love your code, but I have an issue with the menu plugin. In skrollr you check for the existence of require and load it as a modal if its there or else add it to the window instance. In the menu control, you just assume that require.js does not exist and just try to pull it from the window object:
var MENU_DURATION_ATTR = 'data-menu-duration';
var MENU_IGNORE_ATTR = 'data-menu-ignore';
Is this by design?