Skip to content
This repository was archived by the owner on Jan 24, 2018. It is now read-only.
This repository was archived by the owner on Jan 24, 2018. It is now read-only.

No support for require.js #79

@haggis777

Description

@haggis777

Love your code, but I have an issue with the menu plugin. In skrollr you check for the existence of require and load it as a modal if its there or else add it to the window instance. In the menu control, you just assume that require.js does not exist and just try to pull it from the window object:

var MENU_DURATION_ATTR = 'data-menu-duration';
var MENU_IGNORE_ATTR = 'data-menu-ignore';

var skrollr = window.skrollr; <-------- is this right?
var history = window.history;
var supportsHistory = !!history.pushState;

Is this by design?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions