data-menu-offset percentage offset

[toneffectory]

currently, data-menu-offset can't handle percentage offsets.
I fixed it by changing line 134 to:

                //Is it a percentage offset?
                if(/p$/.test(menuOffset)) {
                    targetTop += (menuOffset.slice(0, -1) / 100) * document.documentElement.clientHeight;
                } else {
                    targetTop += +menuOffset;
                }

Can you add this to the source?

[Prinzhorn]

You have a fluid-height navigation? Or what's your use-case?

[toneffectory]

the height of the top bar changes due to a skrollr action (i'm not using it
as navigation bar, but as logo bar, but still, idea is the same). See
http://www.ja-doe.nl

This site uses the skrollr menu library that I adapted.

BR
Leo

On Fri, Mar 20, 2015 at 10:09 AM, Alexander Prinzhorn <
notifications@github.com> wrote:

You have a fluid-height navigation? Or what's your use-case?

—
Reply to this email directly or view it on GitHub
#71 (comment)
.

[wuuti]

It is also not possible to give an offset other than px - e.g. em/rem - it would be great if skrollrmenu would support the possible css values here.