Skip to content

Commit f1ca2a8

Browse files
committed
Do not use a global for the request's unique id
It wil break things when having more than one request pending
1 parent 4bdd41e commit f1ca2a8

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

.luacheckrc

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/nats.lua

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -389,16 +389,17 @@ end
389389

390390
function command.request(client, subject, payload, callback)
391391
local inbox = create_inbox()
392-
unique_id = client:subscribe(inbox, function(message, reply)
392+
local unique_id = uuid()
393+
client:subscribe(inbox, function(message, reply)
393394
client:unsubscribe(unique_id)
394395
callback(message, reply)
395-
end)
396+
end, unique_id)
396397
client:publish(subject, payload, inbox)
397398
return unique_id, inbox
398399
end
399400

400-
function command.subscribe(client, subject, callback)
401-
local unique_id = uuid()
401+
function command.subscribe(client, subject, callback, unique_id)
402+
unique_id = unique_id or uuid()
402403
request.raw(client, 'SUB '..subject..' '..unique_id..'\r\n')
403404
client.subscriptions[unique_id] = callback
404405

0 commit comments

Comments
 (0)