diff --git a/README.md b/README.md index f1fdd11..29ad442 100644 --- a/README.md +++ b/README.md @@ -26,7 +26,7 @@ auth_params = BaoAuthParams( try: bao_client = Bao(auth_params=auth_params) except Exception as ex: - print(f'Could not connect to openbao: { bao_ip_address } - { ex }') + print(f'Could not connect to openbao: { auth_params.bao_address } - { ex }') sys.exit(1) ``` @@ -43,7 +43,7 @@ auth_params = BaoAuthParams( try: bao_client = Bao(auth_params=auth_params) except Exception as ex: - print(f'Could not connect to openbao: { bao_ip_address } - { ex }') + print(f'Could not connect to openbao: { ex }') sys.exit(1) ``` @@ -58,6 +58,7 @@ try: response = bao_client.generate_certificate( common_name=server_fqdn, pki="mycool-ca", + ttl="72h", pki_role="mycool-ca-role" ) diff --git a/openbaopy/bao.py b/openbaopy/bao.py index 6077379..6ef8177 100644 --- a/openbaopy/bao.py +++ b/openbaopy/bao.py @@ -96,12 +96,13 @@ def __init__(self, auth_params: BaoAuthParams): if not self.__bao_client.is_authenticated(): raise hvac.exceptions.Unauthorized('Cloud not authenticate to bao server!') - def generate_certificate(self, common_name: str, pki: str, pki_role: str) -> dict: + def generate_certificate(self, common_name: str, ttl: str, pki: str, pki_role: str) -> dict: """ Generate new signed x509 certificate. Args: common_name (str): The Certificates desired Common Name. + ttl (str): The certificates desired expiration e.g: 72h. pki (str): The CA/PKI mount to issue new certificates. pki_role (str): The desired openbao pki role. @@ -115,6 +116,7 @@ def generate_certificate(self, common_name: str, pki: str, pki_role: str) -> dic response = self.__bao_client.secrets.pki.generate_certificate( name=pki_role, common_name=common_name, + ttl=ttl, mount_point=pki ) return response['data'] diff --git a/pyproject.toml b/pyproject.toml index 987f77f..ff69c4b 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta" [project] name = "openbaopy" -version = "1.0.0" +version = "1.0.1" description = "OpenBao client library" readme = "README.md" requires-python = ">=3.12"