Skip to content

Does doActiveScan for each param of each request will make it more "distributed"? #5

@osxtest

Description

@osxtest

Hi @albinowax

I notice that we will create a scan task for a request and its all eligible params according to the config.

IScanQueueItem scanItem = callbacks.doActiveScan(host, service.getPort(), using_https, itemToScanNext.getRequest(), next.offsets);

So I was thinking if we could create scan task for each param of each request, e.g.

if (!BurpExtender.scanned.contains(param_id)) {
insertionPoints.add(new int[]{param.getValueStart(),param.getValueEnd()});
BurpExtender.scanned.add(param_id);
}

		if (!BurpExtender.scanned.contains(param_id)) {
-			insertionPoints.add(new int[]{param.getValueStart(),param.getValueEnd()});
+			List<int[]> insertionPoint = new ArrayList<>();
+			insertionPoint.add(new int[]{param.getValueStart(), param.getValueEnd()});
+			if (scanItemsByHost.containsKey(host)) {
+				scanItemsByHost.get(host).add(new WorkTarget(request, insertionPoint));
+			} else {
+				ArrayDeque<WorkTarget> newQueue = new ArrayDeque<>();
+				newQueue.add(new WorkTarget(request, insertionPoint));
+				scanItemsByHost.put(host, newQueue);
+			}
			BurpExtender.scanned.add(param_id);
		}
	}

-	if (insertionPoints.isEmpty()) {
-		continue;
-	}
-
-	if (scanItemsByHost.containsKey(host)) {
-		scanItemsByHost.get(host).add(new WorkTarget(request, insertionPoints));
-	} else {
-		ArrayDeque<WorkTarget> newQueue = new ArrayDeque<>();
-		newQueue.add(new WorkTarget(request, insertionPoints));
-		scanItemsByHost.put(host, newQueue);
-	}

By doing this, we will create more scan tasks, and hopefully will make it more "distributed".

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions