fix(consensus): correct test expectations for 33% default threshold

- test_consensus_threshold: update comments and expected values for 33% threshold
- test_consensus_with_8_validators: use explicit 50% threshold config to match ChainState

Author: echobt

crates/consensus/src/state.rs

@@ -156,11 +156,12 @@ mod tests {
     fn test_consensus_threshold() {
         let state = ConsensusState::new(ConsensusConfig::default());
 
-        // Test with 8 validators (50% = 4)
+        // Default threshold is 33% (0.33)
+        // Test with 8 validators: ceil(8 * 0.33) = ceil(2.64) = 3
         state.set_validator_count(8);
-        assert_eq!(state.threshold(), 4);
+        assert_eq!(state.threshold(), 3);
 
-        // Test with 4 validators (50% = 2)
+        // Test with 4 validators: ceil(4 * 0.33) = ceil(1.32) = 2
         state.set_validator_count(4);
         assert_eq!(state.threshold(), 2);
     }

crates/consensus/tests/integration_test.rs

@@ -32,8 +32,12 @@ async fn test_consensus_with_8_validators() {
     // Consensus threshold for 8 validators at 50% = 4
     assert_eq!(state.consensus_threshold(), 4);
 
-    // Create consensus state
-    let consensus_state = ConsensusState::new(ConsensusConfig::default());
+    // Create consensus state with 50% threshold to match ChainState behavior
+    let config = ConsensusConfig {
+        threshold: 0.5, // 50% to match ChainState.consensus_threshold()
+        ..Default::default()
+    };
+    let consensus_state = ConsensusState::new(config);
     consensus_state.set_validator_count(8);
 
     // Create a proposal