fix: prevent 1010 duplicate commit errors after validator restart

- Init last_weight_submission_epoch to current epoch at boot (not 0)
  so we don't re-submit for an epoch we may have already committed to
- Remove first_block_seen CommitWindowOpen (caused immediate duplicate)
- Disable startup weight timer (redundant with PhaseChange handler)
- Weights now submit cleanly at the next epoch boundary via CommitWindowOpen

Author: echobt

bins/validator-node/src/main.rs

@@ -1637,37 +1637,12 @@ async fn main() -> Result<()> {
                 }
             }
 
-            // Submit weights on-chain 90s after boot (after RPC pre-compute at 70s).
+            // Startup weight timer disabled: we init last_weight_submission_epoch to current
+            // epoch to avoid 1010 duplicate commit errors after restart. Weights will be
+            // submitted on the next epoch boundary via CommitWindowOpen from block_sync.
             _ = &mut startup_weight_delay, if !startup_weights_submitted => {
                 startup_weights_submitted = true;
-                let current_block = state_manager.apply(|state| state.bittensor_block);
-                if current_block == 0 {
-                    warn!("Startup weight submission skipped: blockchain not yet synced");
-                } else if subtensor.is_none() || subtensor_signer.is_none() {
-                    warn!("Startup weight submission skipped: subtensor not connected");
-                } else if wasm_executor.is_none() {
-                    warn!("Startup weight submission skipped: WASM executor not ready");
-                } else {
-                    let has_challenges = {
-                        let cs = chain_state.read();
-                        cs.wasm_challenge_configs.iter().any(|(_, cfg)| cfg.is_active)
-                    };
-                    if !has_challenges {
-                        warn!("Startup weight submission skipped: no active challenges loaded");
-                    } else {
-                        let tempo = 360u64;
-                        let netuid_plus_one = (netuid as u64).saturating_add(1);
-                        let epoch = current_block.saturating_add(netuid_plus_one) / (tempo + 1);
-                        info!("Startup weight submission: epoch {} block {} (90s after boot)", epoch, current_block);
-                        handle_block_event(
-                            BlockSyncEvent::CommitWindowOpen { epoch, block: current_block },
-                            &subtensor, &subtensor_signer, &subtensor_client,
-                            &state_manager, netuid, version_key, &wasm_executor,
-                            &keypair, &chain_state, &storage,
-                            &mut last_weight_submission_epoch,
-                        ).await;
-                    }
-                }
+                info!("Startup weight timer fired (no-op): weights will submit at next epoch boundary");
             }
 
             // Periodic checkpoint

crates/bittensor-integration/src/block_sync.rs

@@ -231,22 +231,12 @@ impl BlockSync {
                 *current_epoch.write().await = epoch_info.epoch_number;
                 *current_phase.write().await = epoch_info.phase;
 
-                // On first block after startup, trigger immediate weight submission
-                // so the validator doesn't have to wait for the next epoch boundary.
                 if !*first_block_seen {
                     *first_block_seen = true;
-                    if epoch_info.commit_reveal_enabled {
-                        info!(
-                            "First block after startup: triggering immediate weight submission (epoch={}, block={})",
-                            epoch_info.epoch_number, block_number
-                        );
-                        let _ = event_tx
-                            .send(BlockSyncEvent::CommitWindowOpen {
-                                epoch: epoch_info.epoch_number,
-                                block: block_number,
-                            })
-                            .await;
-                    }
+                    info!(
+                        "First block seen after startup: epoch={}, block={}. Weights will submit at next epoch boundary.",
+                        epoch_info.epoch_number, block_number
+                    );
                 }
 
                 if let Err(e) = event_tx
@@ -463,13 +453,11 @@ mod tests {
             EpochPhase::CommitWindow
         ));
 
-        // First event: CommitWindowOpen (triggered on first block after startup)
+        // First event: NewBlock (first_block_seen no longer emits CommitWindowOpen)
         let first = rx.recv().await.unwrap();
-        assert!(matches!(first, BlockSyncEvent::CommitWindowOpen { .. }));
+        assert!(matches!(first, BlockSyncEvent::NewBlock { .. }));
         let second = rx.recv().await.unwrap();
-        assert!(matches!(second, BlockSyncEvent::NewBlock { .. }));
-        let third = rx.recv().await.unwrap();
-        assert!(matches!(third, BlockSyncEvent::Reconnected));
+        assert!(matches!(second, BlockSyncEvent::Reconnected));
         assert!(!was_disconnected);
     }